diff options
| author | yzshen@chromium.org <yzshen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-18 08:30:08 +0000 |
|---|---|---|
| committer | yzshen@chromium.org <yzshen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-18 08:30:08 +0000 |
| commit | 93b1f7dc091c0077f70f0cb1be5a07d7463fcb4d (patch) | |
| tree | fb6461ef017832b632263b55145a518cb3582c00 /mojo/apps/js | |
| parent | b989df73881b20a2dc885b85d82e8b609e7549fb (diff) | |
| download | chromium_src-93b1f7dc091c0077f70f0cb1be5a07d7463fcb4d.zip chromium_src-93b1f7dc091c0077f70f0cb1be5a07d7463fcb4d.tar.gz chromium_src-93b1f7dc091c0077f70f0cb1be5a07d7463fcb4d.tar.bz2 | |
InterfacePtr: not setup proxy until actual read/write is needed.
A common usage of InterfacePtr is:
(1) Create a new InterfacePtr instance.
(2) BindToProxy() is called to bind the interface pointer to an implementation.
(3) Immediately, the message pipe handle underneath the interface pointer is detached and sent over another message pipe.
In step (2), currently we do all the setup work for the interface pointer: construct Router and Connector instance, post task to start watching the message pipe handle, etc. All the work is thrown away at step (3).
With this CL, the proxy setup work won't be done until actual read/write is needed.
BUG=394883
TEST=None
Review URL: https://codereview.chromium.org/400043004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284034 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'mojo/apps/js')
| -rw-r--r-- | mojo/apps/js/test/js_to_cpp_unittest.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mojo/apps/js/test/js_to_cpp_unittest.cc b/mojo/apps/js/test/js_to_cpp_unittest.cc index 6d69bc2..206e266 100644 --- a/mojo/apps/js/test/js_to_cpp_unittest.cc +++ b/mojo/apps/js/test/js_to_cpp_unittest.cc @@ -394,7 +394,7 @@ class JsToCppTest : public testing::Test { MakeProxy<js_to_cpp::JsSide>(pipe.handle0.Pass()); js_side.set_client(cpp_side); - js_side.internal_state()->router()->EnableTestingMode(); + js_side.internal_state()->router_for_testing()->EnableTestingMode(); cpp_side->set_js_side(js_side.get()); |