diff options
author | ajay.berwal@samsung.com <ajay.berwal@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-05 09:18:42 +0000 |
---|---|---|
committer | ajay.berwal@samsung.com <ajay.berwal@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-05 09:18:42 +0000 |
commit | 243e4f1996a61098947b5f9ad1798d6b5412ef0b (patch) | |
tree | 647808bf21f492a652d54e8e15c12177ca04e824 /mojo/examples/compositor_app | |
parent | 1e7e41e75151197f026df35b9c01c4bc63bccef0 (diff) | |
download | chromium_src-243e4f1996a61098947b5f9ad1798d6b5412ef0b.zip chromium_src-243e4f1996a61098947b5f9ad1798d6b5412ef0b.tar.gz chromium_src-243e4f1996a61098947b5f9ad1798d6b5412ef0b.tar.bz2 |
Pass gfx structs by const ref (gfx::Vector2d)
Avoid unneccessary copy of structures gfx::Vector2d
by passing them by const ref rather than value.
Any struct of size > 4 bytes should be passed by const ref.
Passing by ref for these structs is faster than passing
by value, especially when invoking function has multiple parameters.
Pass gfx structs by const ref (gfx::Vector2d)
BUG=159273
Review URL: https://codereview.chromium.org/132163009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248941 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'mojo/examples/compositor_app')
-rw-r--r-- | mojo/examples/compositor_app/compositor_host.cc | 2 | ||||
-rw-r--r-- | mojo/examples/compositor_app/compositor_host.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/mojo/examples/compositor_app/compositor_host.cc b/mojo/examples/compositor_app/compositor_host.cc index 6ae3f78..d444dc4 100644 --- a/mojo/examples/compositor_app/compositor_host.cc +++ b/mojo/examples/compositor_app/compositor_host.cc @@ -105,7 +105,7 @@ void CompositorHost::Animate(double frame_begin_time) { } void CompositorHost::Layout() {} -void CompositorHost::ApplyScrollAndScale(gfx::Vector2d scroll_delta, +void CompositorHost::ApplyScrollAndScale(const gfx::Vector2d& scroll_delta, float page_scale) {} scoped_ptr<cc::OutputSurface> CompositorHost::CreateOutputSurface( diff --git a/mojo/examples/compositor_app/compositor_host.h b/mojo/examples/compositor_app/compositor_host.h index ba03a54..a5b470a 100644 --- a/mojo/examples/compositor_app/compositor_host.h +++ b/mojo/examples/compositor_app/compositor_host.h @@ -32,7 +32,7 @@ class CompositorHost : public cc::LayerTreeHostClient { virtual void DidBeginMainFrame() OVERRIDE; virtual void Animate(double frame_begin_time) OVERRIDE; virtual void Layout() OVERRIDE; - virtual void ApplyScrollAndScale(gfx::Vector2d scroll_delta, + virtual void ApplyScrollAndScale(const gfx::Vector2d& scroll_delta, float page_scale) OVERRIDE; virtual scoped_ptr<cc::OutputSurface> CreateOutputSurface(bool fallback) OVERRIDE; |