diff options
| author | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-08 23:21:33 +0000 |
|---|---|---|
| committer | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-08 23:21:33 +0000 |
| commit | bad78b17bfb7153339905a1ae2b285a377142f6a (patch) | |
| tree | e66073db7ec71968db057868772130330326a4d8 /mojo/examples/nesting_app | |
| parent | 8ff7a295f06bf8cdb05a69b0007bf2314c76c35d (diff) | |
| download | chromium_src-bad78b17bfb7153339905a1ae2b285a377142f6a.zip chromium_src-bad78b17bfb7153339905a1ae2b285a377142f6a.tar.gz chromium_src-bad78b17bfb7153339905a1ae2b285a377142f6a.tar.bz2 | |
Remove DispositionChangePhase.
The problem with having a single observer method with a phase param is that it's cumbersome and error prone to use for most clients that just want to know when something *has* changed. I think it's appropriate then to create separate methods for each phase and have the client override the one (or both) that is relevant to them.
TBR=sky@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/374933003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281874 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'mojo/examples/nesting_app')
| -rw-r--r-- | mojo/examples/nesting_app/nesting_app.cc | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/mojo/examples/nesting_app/nesting_app.cc b/mojo/examples/nesting_app/nesting_app.cc index 8e66736..f0b6763 100644 --- a/mojo/examples/nesting_app/nesting_app.cc +++ b/mojo/examples/nesting_app/nesting_app.cc @@ -102,11 +102,7 @@ class NestingApp : public ApplicationDelegate, } // Overridden from NodeObserver: - virtual void OnNodeDestroy( - Node* node, - NodeObserver::DispositionChangePhase phase) OVERRIDE { - if (phase != NodeObserver::DISPOSITION_CHANGED) - return; + virtual void OnNodeDestroyed(Node* node) OVERRIDE { // TODO(beng): reap views & child nodes. nested_ = NULL; } |