diff options
| author | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-17 22:38:30 +0000 |
|---|---|---|
| committer | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-17 22:38:30 +0000 |
| commit | 92fb7f47913d874aa282cab1f81e8d621e637802 (patch) | |
| tree | 560d6f3d7907f9d3931e89e1216962b81716cab9 /mojo/mojo.gyp | |
| parent | 5d0bf8b3808efe91dc8bf8cf44583796e3d3aa02 (diff) | |
| download | chromium_src-92fb7f47913d874aa282cab1f81e8d621e637802.zip chromium_src-92fb7f47913d874aa282cab1f81e8d621e637802.tar.gz chromium_src-92fb7f47913d874aa282cab1f81e8d621e637802.tar.bz2 | |
Mojo: Refactor (local) data pipe creation/initialization.
- Separate out the validation of options.
- Remove |Init()|. Now you can create the LocalDataPipe with your
validated options.
- Once created, the LocalDataPipe has to be shut down correctly. (This
was true before, but broken -- if you ran out of handles in
MojoCreateDataPipe(), DCHECKs would fire.)
- Add tests for the new |DataPipe::ValidateOptions()|.
- Also add a minimal test for LocalDataPipe creation (which led to the
discovery of the above bug, and consequently the above refactoring).
- Change the struct_size field of options to a |uint32_t|. This makes it
much easier to reason about the size of the struct, which we need to
be careful about.
R=sky@chromium.org
Review URL: https://codereview.chromium.org/116573010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241393 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'mojo/mojo.gyp')
| -rw-r--r-- | mojo/mojo.gyp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/mojo/mojo.gyp b/mojo/mojo.gyp index 6980311..7b1930b 100644 --- a/mojo/mojo.gyp +++ b/mojo/mojo.gyp @@ -133,7 +133,9 @@ 'system/core_impl_unittest.cc', 'system/core_test_base.cc', 'system/core_test_base.h', + 'system/data_pipe_unittest.cc', 'system/dispatcher_unittest.cc', + 'system/local_data_pipe_unittest.cc', 'system/message_pipe_dispatcher_unittest.cc', 'system/message_pipe_unittest.cc', 'system/multiprocess_message_pipe_unittest.cc', |