summaryrefslogtreecommitdiffstats
path: root/mojo/mojo_js_unittests.isolate
diff options
context:
space:
mode:
authordpranke <dpranke@chromium.org>2015-05-14 15:52:45 -0700
committerCommit bot <commit-bot@chromium.org>2015-05-14 22:53:58 +0000
commit067d014b8f1918db09939aa765bdfa7576ab3d50 (patch)
treeeafb9198a3f35ce530cda8d700c944a216ad9419 /mojo/mojo_js_unittests.isolate
parentac496302b1d0ada0bbe8ef7beecfdff67d480c6b (diff)
downloadchromium_src-067d014b8f1918db09939aa765bdfa7576ab3d50.zip
chromium_src-067d014b8f1918db09939aa765bdfa7576ab3d50.tar.gz
chromium_src-067d014b8f1918db09939aa765bdfa7576ab3d50.tar.bz2
Modify the gn version of 'mb analyze' to handle GN group targets as well.
Previously, if a group target like 'mandoline:all' was specified as an additional_compile_target that we wanted to build, the gn implementation of 'analyze' would not handle it correctly (it could only handle dependencies on files that existed in the build directory, like executables). This patch modifies the MB implementation to also handle label-like targets (the ninja mandoline:all target is the equivalent of the GN //mandonline:all target); we do this by calling 'gn refs' twice, once looking for a list of output paths to match against the compile targets and once looking for a list of phony labels to match against the compile targets. We also will match against just the target_name, so 'chrome_shell_apk' will also match "//chrome/android:chrome_shell_apk'. This may result in too many targets being rebuilt, but we can adjust that if need be. This is somewhat inefficient, but the alternatives would be to either 1) force the user to specify the stamp files for a group, which would be ugly, or 2) force the user to specify all the compile targets in terms of GN labels, which would be different from how the recipes work w/ GYP and possibly require us to map binary names to targets outside of GN, which would be a maintenance headache. R=scottmg@chromium.org,brettw@chromium.org BUG=487035 CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel;tryserver.chromium.win:win8_chromium_gn_rel Review URL: https://codereview.chromium.org/1135743005 Cr-Commit-Position: refs/heads/master@{#329964}
Diffstat (limited to 'mojo/mojo_js_unittests.isolate')
0 files changed, 0 insertions, 0 deletions