diff options
| author | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-24 12:19:09 +0000 |
|---|---|---|
| committer | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-24 12:19:09 +0000 |
| commit | f95da62fc7a0b0aa0ffe51ac72b2159409dd3717 (patch) | |
| tree | 7a918af502e969bec3252eaae82279ff8d5bc66c /mojo/services | |
| parent | 0f8ff5ecdc7386fe3382041384b9199110d20699 (diff) | |
| download | chromium_src-f95da62fc7a0b0aa0ffe51ac72b2159409dd3717.zip chromium_src-f95da62fc7a0b0aa0ffe51ac72b2159409dd3717.tar.gz chromium_src-f95da62fc7a0b0aa0ffe51ac72b2159409dd3717.tar.bz2 | |
sync: Refactor StatusChangeChecker hierarchy
Refactors the StatusChangeChecker class hierarchy to allow for more code
sharing. Allows children of StatusChangeChecker to share logic around
performing a blocking wait, checking exit conditions, and timing out.
As before, the sharing is acheived through inheritance. We should move
to a delegation pattern if this becomes too complicated, but I think the
use of inheritance still makes sense for now.
This is a pre-requisite for a future patch that adds a new kind of
StatusChangeChecker that does not listen to ProfileSyncService changes.
I expect that there will be many more kinds of StatusChangeCheckers
defined in the future. This refactoring will help us share code between
them.
This is attached to issue 97780 and 95742 because it will enable us to
write more StatusChangeCheckers that we can use to refactor tests that
currently listen for snapshots and self-notifications.
BUG=97780,95742
Review URL: https://codereview.chromium.org/299843007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272711 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'mojo/services')
0 files changed, 0 insertions, 0 deletions