diff options
| author | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-12 06:12:00 +0000 |
|---|---|---|
| committer | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-12 06:12:00 +0000 |
| commit | 9b23bd4cdf20ad2e3bd7a9645ce7c79279f36c71 (patch) | |
| tree | 745e85ebbd1af4e66bc51f147c23270e79d64c58 /mojo | |
| parent | eb865fc5d4c26dcd36ab05f7a2b5c16702739f31 (diff) | |
| download | chromium_src-9b23bd4cdf20ad2e3bd7a9645ce7c79279f36c71.zip chromium_src-9b23bd4cdf20ad2e3bd7a9645ce7c79279f36c71.tar.gz chromium_src-9b23bd4cdf20ad2e3bd7a9645ce7c79279f36c71.tar.bz2 | |
Reland Merge NativeTextfieldViews into views::Textfield.
Reverted in r244402 for Linux-Aura test failures.
I fixed Ctrl+Shift+Delete/Backspace behavior on Linux here.
Consolidate the split textfield code into Textfield.
No behavior changes (except STYLE_LOWERCASE GetText nit).
Use the underlying model's text and font_list storage.
Remove unused code; rename TextfieldViewsModel::text().
Revise gesture and command handling.
Skip NotifyAccessibilityEvent native behavior without widget.
(No HWND for Views not yet added to view hierarchy)
Make TouchEditable::GetNativeView const; avoids conflict.
Fix includes, forward decls, Font[List] usage, tests.
Ideas for followup cleanup and refactoring:
-Cleanup View overrides decl/def order.
-Refactor RemoveBorder, SetHorizontalMargins, etc.
-Try to use composition instead of inheritance.
-Remove textfield style ctor; refactor style code.
-Remove STYLE_LOWERCASE functionality (one user).
-Replace placeholder DrawStringRect with a Label view.
-Cleanup CreateTouchSelectionControllerAndNotifyIt, etc.
-Cleanup SetColor/SetTextColor, etc.
BUG=131660
TEST=No textfield behavior/appearance regressions.
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/135863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244436 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'mojo')
0 files changed, 0 insertions, 0 deletions