diff options
| author | dpranke@chromium.org <dpranke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-31 12:28:12 +0000 |
|---|---|---|
| committer | dpranke@chromium.org <dpranke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-31 12:28:12 +0000 |
| commit | cc4db170df2da833f480a27c4a692d3c10df41df (patch) | |
| tree | 13801bfb88fd3a2e918504d1ea09492744399446 /mojo | |
| parent | 0cd5b7e79c21dc40a74a6c6b0705d2f850a4a4dc (diff) | |
| download | chromium_src-cc4db170df2da833f480a27c4a692d3c10df41df.zip chromium_src-cc4db170df2da833f480a27c4a692d3c10df41df.tar.gz chromium_src-cc4db170df2da833f480a27c4a692d3c10df41df.tar.bz2 | |
Mark json results failures as unexpected in python tests.
If we don't mark the failures as unexpected, the result-reading
logic on the bots views the failures as expected and hence
ignores them, leading us to let bad changes through :(.
TBR=ojan@chromium.org, viettrungluu@chromium.org, tonyg@chromium.org, grt@chromium.org
BUG=264859, 323212, 398027
Review URL: https://codereview.chromium.org/430933004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286761 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'mojo')
| -rwxr-xr-x | mojo/tools/run_mojo_python_tests.py | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/mojo/tools/run_mojo_python_tests.py b/mojo/tools/run_mojo_python_tests.py index da9ab63..6adac58 100755 --- a/mojo/tools/run_mojo_python_tests.py +++ b/mojo/tools/run_mojo_python_tests.py @@ -95,10 +95,13 @@ def _FullResults(suite, result, metadata): full_results['tests'] = {} for test_name in all_test_names: - value = { - 'expected': 'PASS', - 'actual': 'FAIL' if (test_name in failed_test_names) else 'PASS', - } + value = {} + value['expected'] = 'PASS' + if test_name in failed_test_names: + value['actual'] = 'FAIL' + value['is_unexpected'] = True + else: + value['actual'] = 'PASS' _AddPathToTrie(full_results['tests'], test_name, value) return full_results |