summaryrefslogtreecommitdiffstats
path: root/native_client_sdk
diff options
context:
space:
mode:
authormaruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-12-13 23:43:56 +0000
committermaruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-12-13 23:43:56 +0000
commit28fda8234188d910851a2b3af877d20d4fe29638 (patch)
tree0824378a53282b71c06fa90d1275cf604c465ff4 /native_client_sdk
parent613b3f520b2b8f623a108007bc14054743dcbf85 (diff)
downloadchromium_src-28fda8234188d910851a2b3af877d20d4fe29638.zip
chromium_src-28fda8234188d910851a2b3af877d20d4fe29638.tar.gz
chromium_src-28fda8234188d910851a2b3af877d20d4fe29638.tar.bz2
Fix create_nmf.py on non-English locale.
It would fail parsing localized string otherwise. For example 'file format' is 'format de fichier' with LANG=fr_CA.UTF-8. Fix file_arch could be used before being assigned. R=sbc@chromium.org BUG= Review URL: https://codereview.chromium.org/108213002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240802 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'native_client_sdk')
-rwxr-xr-xnative_client_sdk/src/tools/create_nmf.py14
1 files changed, 8 insertions, 6 deletions
diff --git a/native_client_sdk/src/tools/create_nmf.py b/native_client_sdk/src/tools/create_nmf.py
index ea33a30..704b385 100755
--- a/native_client_sdk/src/tools/create_nmf.py
+++ b/native_client_sdk/src/tools/create_nmf.py
@@ -291,8 +291,10 @@ class NmfUtils(object):
cmd = [self.objdump, '-p'] + list(full_paths)
DebugPrint('GleanFromObjdump[%s](%s)' % (arch, cmd))
+ env = {'LANG': 'en_US.UTF-8'}
proc = subprocess.Popen(cmd, stdout=subprocess.PIPE,
- stderr=subprocess.PIPE, bufsize=-1)
+ stderr=subprocess.PIPE, bufsize=-1,
+ env=env)
input_info = {}
found_basenames = set()
@@ -318,11 +320,11 @@ class NmfUtils(object):
name=name,
path=filename,
url='/'.join(self.lib_prefix + [ARCH_LOCATION[file_arch], name]))
- matched = NeededMatcher.match(line)
- if matched:
- match = '/'.join([file_arch, matched.group(1)])
- needed.add(match)
- Trace("NEEDED: %s" % match)
+ matched = NeededMatcher.match(line)
+ if matched:
+ match = '/'.join([file_arch, matched.group(1)])
+ needed.add(match)
+ Trace("NEEDED: %s" % match)
for filename in files:
if os.path.basename(filename) not in found_basenames: