summaryrefslogtreecommitdiffstats
path: root/native_client_sdk
diff options
context:
space:
mode:
authorphilipj@opera.com <philipj@opera.com@0039d316-1c4b-4281-b951-d872f2087c98>2013-12-11 03:41:19 +0000
committerphilipj@opera.com <philipj@opera.com@0039d316-1c4b-4281-b951-d872f2087c98>2013-12-11 03:41:19 +0000
commitdf68790dcf69e3594d6cfb62fddc07115419c406 (patch)
tree531da2d7bbfd4aa8e4beefafe3444493430befe6 /native_client_sdk
parent5ece8ffac66d612a805d13f70568317d109b2b1c (diff)
downloadchromium_src-df68790dcf69e3594d6cfb62fddc07115419c406.zip
chromium_src-df68790dcf69e3594d6cfb62fddc07115419c406.tar.gz
chromium_src-df68790dcf69e3594d6cfb62fddc07115419c406.tar.bz2
Add missing argument to Element.setAttribute() calls
"Make arguments to Element methods non-optional" was reverted in Blink because these tests began failing. BUG=325922 Review URL: https://codereview.chromium.org/111833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239999 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'native_client_sdk')
-rw-r--r--native_client_sdk/src/examples/api/file_io/example.js2
-rw-r--r--native_client_sdk/src/examples/api/var_dictionary/example.js2
-rw-r--r--native_client_sdk/src/examples/demo/drive/example.js4
-rw-r--r--native_client_sdk/src/examples/demo/nacl_io/example.js2
-rw-r--r--native_client_sdk/src/gonacl_appengine/static/frame.js2
5 files changed, 6 insertions, 6 deletions
diff --git a/native_client_sdk/src/examples/api/file_io/example.js b/native_client_sdk/src/examples/api/file_io/example.js
index 6143fd5..81a4717 100644
--- a/native_client_sdk/src/examples/api/file_io/example.js
+++ b/native_client_sdk/src/examples/api/file_io/example.js
@@ -45,7 +45,7 @@ function onRadioClicked(e) {
if (functionEls[i].id === divId)
functionEls[i].removeAttribute('hidden');
else
- functionEls[i].setAttribute('hidden');
+ functionEls[i].setAttribute('hidden', '');
}
}
diff --git a/native_client_sdk/src/examples/api/var_dictionary/example.js b/native_client_sdk/src/examples/api/var_dictionary/example.js
index d0c58b7..508dad1 100644
--- a/native_client_sdk/src/examples/api/var_dictionary/example.js
+++ b/native_client_sdk/src/examples/api/var_dictionary/example.js
@@ -29,7 +29,7 @@ function onRadioClicked(e) {
if (functionEls[i].id === divId)
functionEls[i].removeAttribute('hidden');
else
- functionEls[i].setAttribute('hidden');
+ functionEls[i].setAttribute('hidden', '');
}
}
diff --git a/native_client_sdk/src/examples/demo/drive/example.js b/native_client_sdk/src/examples/demo/drive/example.js
index ae6326f..95956b2 100644
--- a/native_client_sdk/src/examples/demo/drive/example.js
+++ b/native_client_sdk/src/examples/demo/drive/example.js
@@ -15,7 +15,7 @@ function onGetAuthToken(authToken) {
var signInEl = document.getElementById('signIn');
var getFileEl = document.getElementById('getFile');
if (authToken) {
- signInEl.setAttribute('hidden');
+ signInEl.setAttribute('hidden', '');
getFileEl.removeAttribute('hidden');
window.authToken = authToken;
@@ -26,7 +26,7 @@ function onGetAuthToken(authToken) {
// this app. Display a button to let the user sign in and authorize this
// application.
signInEl.removeAttribute('hidden');
- getFileEl.setAttribute('hidden');
+ getFileEl.setAttribute('hidden', '');
}
};
diff --git a/native_client_sdk/src/examples/demo/nacl_io/example.js b/native_client_sdk/src/examples/demo/nacl_io/example.js
index 0ccaf7d..9c0a513f 100644
--- a/native_client_sdk/src/examples/demo/nacl_io/example.js
+++ b/native_client_sdk/src/examples/demo/nacl_io/example.js
@@ -46,7 +46,7 @@ function onRadioClicked(e) {
if (functionEls[i].id === divId)
functionEls[i].removeAttribute('hidden');
else
- functionEls[i].setAttribute('hidden');
+ functionEls[i].setAttribute('hidden', '');
}
}
diff --git a/native_client_sdk/src/gonacl_appengine/static/frame.js b/native_client_sdk/src/gonacl_appengine/static/frame.js
index 580d994..eca667e 100644
--- a/native_client_sdk/src/gonacl_appengine/static/frame.js
+++ b/native_client_sdk/src/gonacl_appengine/static/frame.js
@@ -138,7 +138,7 @@ function createIframe(src) {
iframeEl.setAttribute('width', '100%');
iframeEl.setAttribute('height', '100%');
iframeEl.src = src;
- iframeEl.setAttribute('hidden');
+ iframeEl.setAttribute('hidden', '');
iframeEl.onload = function() {
if (oldIframeEl)
oldIframeEl.parentNode.removeChild(oldIframeEl);