summaryrefslogtreecommitdiffstats
path: root/net/android
diff options
context:
space:
mode:
authoraurimas <aurimas@chromium.org>2014-11-20 10:46:00 -0800
committerCommit bot <commit-bot@chromium.org>2014-11-20 18:46:15 +0000
commitcee75f0a7905c9e232900252142853a8b11d9701 (patch)
tree93d58fa0f6324b05e350ca4d81ba7063117dc1d8 /net/android
parent522a6a68af27cc55510c9d27b3407ff49143b9e3 (diff)
downloadchromium_src-cee75f0a7905c9e232900252142853a8b11d9701.zip
chromium_src-cee75f0a7905c9e232900252142853a8b11d9701.tar.gz
chromium_src-cee75f0a7905c9e232900252142853a8b11d9701.tar.bz2
Fix a bunch of Java Checkstyle issues.
BUG=318404 TBR=samuong@chromium.org Review URL: https://codereview.chromium.org/744453002 Cr-Commit-Position: refs/heads/master@{#305047}
Diffstat (limited to 'net/android')
-rw-r--r--net/android/java/src/org/chromium/net/DefaultAndroidKeyStore.java12
-rw-r--r--net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java4
-rw-r--r--net/android/java/src/org/chromium/net/X509Util.java20
3 files changed, 18 insertions, 18 deletions
diff --git a/net/android/java/src/org/chromium/net/DefaultAndroidKeyStore.java b/net/android/java/src/org/chromium/net/DefaultAndroidKeyStore.java
index 60f910c..2a6c2f2 100644
--- a/net/android/java/src/org/chromium/net/DefaultAndroidKeyStore.java
+++ b/net/android/java/src/org/chromium/net/DefaultAndroidKeyStore.java
@@ -123,8 +123,8 @@ public class DefaultAndroidKeyStore implements AndroidKeyStore {
signature.update(message);
return signature.sign();
} catch (Exception e) {
- Log.e(TAG, "Exception while signing message with " + javaKey.getAlgorithm() +
- " private key: " + e);
+ Log.e(TAG, "Exception while signing message with " + javaKey.getAlgorithm()
+ + " private key: " + e);
return null;
}
}
@@ -170,8 +170,8 @@ public class DefaultAndroidKeyStore implements AndroidKeyStore {
// This may happen if the PrivateKey was not created by the "AndroidOpenSSL"
// provider, which should be the default. That could happen if an OEM decided
// to implement a different default provider. Also highly unlikely.
- Log.e(TAG, "Private key is not an OpenSSLRSAPrivateKey instance, its class name is:" +
- javaKey.getClass().getCanonicalName());
+ Log.e(TAG, "Private key is not an OpenSSLRSAPrivateKey instance, its class name is:"
+ + javaKey.getClass().getCanonicalName());
return null;
}
@@ -284,8 +284,8 @@ public class DefaultAndroidKeyStore implements AndroidKeyStore {
}
// Sanity-check the returned engine.
if (!engineClass.isInstance(engine)) {
- Log.e(TAG, "Engine is not an OpenSSLEngine instance, its class name is:" +
- engine.getClass().getCanonicalName());
+ Log.e(TAG, "Engine is not an OpenSSLEngine instance, its class name is:"
+ + engine.getClass().getCanonicalName());
return null;
}
return engine;
diff --git a/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java b/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java
index 1e72da9..9db46e2 100644
--- a/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java
+++ b/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java
@@ -161,8 +161,8 @@ public class NetworkChangeNotifierAutoDetect extends BroadcastReceiver
public int getCurrentConnectionType() {
// Track exactly what type of connection we have.
- if (!mConnectivityManagerDelegate.activeNetworkExists() ||
- !mConnectivityManagerDelegate.isConnected()) {
+ if (!mConnectivityManagerDelegate.activeNetworkExists()
+ || !mConnectivityManagerDelegate.isConnected()) {
return NetworkChangeNotifier.CONNECTION_NONE;
}
diff --git a/net/android/java/src/org/chromium/net/X509Util.java b/net/android/java/src/org/chromium/net/X509Util.java
index 3f6c70d..08ead31 100644
--- a/net/android/java/src/org/chromium/net/X509Util.java
+++ b/net/android/java/src/org/chromium/net/X509Util.java
@@ -372,8 +372,8 @@ public class X509Util {
// If the subject and public key match, this is a system root.
X509Certificate anchorX509 = (X509Certificate) anchor;
- if (root.getSubjectX500Principal().equals(anchorX509.getSubjectX500Principal()) &&
- root.getPublicKey().equals(anchorX509.getPublicKey())) {
+ if (root.getSubjectX500Principal().equals(anchorX509.getSubjectX500Principal())
+ && root.getPublicKey().equals(anchorX509.getPublicKey())) {
sSystemTrustAnchorCache.add(key);
return true;
}
@@ -405,10 +405,10 @@ public class X509Util {
if (ekuOids == null) return true;
for (String ekuOid : ekuOids) {
- if (ekuOid.equals(OID_TLS_SERVER_AUTH) ||
- ekuOid.equals(OID_ANY_EKU) ||
- ekuOid.equals(OID_SERVER_GATED_NETSCAPE) ||
- ekuOid.equals(OID_SERVER_GATED_MICROSOFT)) {
+ if (ekuOid.equals(OID_TLS_SERVER_AUTH)
+ || ekuOid.equals(OID_ANY_EKU)
+ || ekuOid.equals(OID_SERVER_GATED_NETSCAPE)
+ || ekuOid.equals(OID_SERVER_GATED_MICROSOFT)) {
return true;
}
}
@@ -421,8 +421,8 @@ public class X509Util {
String host)
throws KeyStoreException, NoSuchAlgorithmException {
if (certChain == null || certChain.length == 0 || certChain[0] == null) {
- throw new IllegalArgumentException("Expected non-null and non-empty certificate " +
- "chain passed as |certChain|. |certChain|=" + Arrays.deepToString(certChain));
+ throw new IllegalArgumentException("Expected non-null and non-empty certificate "
+ + "chain passed as |certChain|. |certChain|=" + Arrays.deepToString(certChain));
}
@@ -475,8 +475,8 @@ public class X509Util {
} catch (CertificateException eTestManager) {
// Neither of the trust managers confirms the validity of the certificate chain,
// log the error message returned by the system trust manager.
- Log.i(TAG, "Failed to validate the certificate chain, error: " +
- eDefaultManager.getMessage());
+ Log.i(TAG, "Failed to validate the certificate chain, error: "
+ + eDefaultManager.getMessage());
return new AndroidCertVerifyResult(
CertVerifyStatusAndroid.NO_TRUSTED_ROOT);
}