summaryrefslogtreecommitdiffstats
path: root/net/base/address_list.cc
diff options
context:
space:
mode:
authoreroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-05-16 23:37:07 +0000
committereroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-05-16 23:37:07 +0000
commit378b387cef8060d5534b5e7a520b88b8cd10ac2d (patch)
tree7b3ad2b93a8a3faffb285d7cdac9a3a3ff2ead29 /net/base/address_list.cc
parent824da7d9904861f35056f756abad9545404b5ca9 (diff)
downloadchromium_src-378b387cef8060d5534b5e7a520b88b8cd10ac2d.zip
chromium_src-378b387cef8060d5534b5e7a520b88b8cd10ac2d.tar.gz
chromium_src-378b387cef8060d5534b5e7a520b88b8cd10ac2d.tar.bz2
Re-order the declarations in AddressList to comply with style.
(this was a TODO from an earlier refactor). This is a no-op change, just re-ordering methods. Review URL: http://codereview.chromium.org/7015029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85553 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/base/address_list.cc')
-rw-r--r--net/base/address_list.cc106
1 files changed, 53 insertions, 53 deletions
diff --git a/net/base/address_list.cc b/net/base/address_list.cc
index 70b94b2..8cda64f 100644
--- a/net/base/address_list.cc
+++ b/net/base/address_list.cc
@@ -45,6 +45,18 @@ struct AddressList::Data : public base::RefCountedThreadSafe<Data> {
AddressList::AddressList() {
}
+AddressList::AddressList(const AddressList& addresslist)
+ : data_(addresslist.data_) {
+}
+
+AddressList::~AddressList() {
+}
+
+AddressList& AddressList::operator=(const AddressList& addresslist) {
+ data_ = addresslist.data_;
+ return *this;
+}
+
// static
AddressList AddressList::CreateFromIPAddress(
const IPAddressNumber& address,
@@ -102,17 +114,6 @@ AddressList AddressList::CreateFromIPAddressWithCname(
return AddressList(new Data(ai, false /*is_system_created*/));
}
-AddressList::AddressList(const AddressList& addresslist)
- : data_(addresslist.data_) {
-}
-
-AddressList::~AddressList() {
-}
-
-AddressList& AddressList::operator=(const AddressList& addresslist) {
- data_ = addresslist.data_;
- return *this;
-}
// static
AddressList AddressList::CreateByAdoptingFromSystem(struct addrinfo* head) {
@@ -132,6 +133,47 @@ AddressList AddressList::CreateByCopyingFirstAddress(
false /*is_system_created*/));
}
+// static
+AddressList AddressList::CreateFromSockaddr(
+ const struct sockaddr* address,
+ socklen_t address_length,
+ int socket_type,
+ int protocol) {
+ // Do sanity checking on socket_type and protocol.
+ DCHECK(socket_type == SOCK_DGRAM || socket_type == SOCK_STREAM);
+ DCHECK(protocol == IPPROTO_TCP || protocol == IPPROTO_UDP);
+
+ struct addrinfo* ai = new addrinfo;
+ memset(ai, 0, sizeof(addrinfo));
+ switch (address_length) {
+ case sizeof(struct sockaddr_in):
+ {
+ const struct sockaddr_in* sin =
+ reinterpret_cast<const struct sockaddr_in*>(address);
+ ai->ai_family = sin->sin_family;
+ DCHECK_EQ(AF_INET, ai->ai_family);
+ }
+ break;
+ case sizeof(struct sockaddr_in6):
+ {
+ const struct sockaddr_in6* sin6 =
+ reinterpret_cast<const struct sockaddr_in6*>(address);
+ ai->ai_family = sin6->sin6_family;
+ DCHECK_EQ(AF_INET6, ai->ai_family);
+ }
+ break;
+ default:
+ NOTREACHED() << "Bad IP address";
+ break;
+ }
+ ai->ai_socktype = socket_type;
+ ai->ai_protocol = protocol;
+ ai->ai_addrlen = address_length;
+ ai->ai_addr = reinterpret_cast<struct sockaddr*>(new char[address_length]);
+ memcpy(ai->ai_addr, address, address_length);
+ return AddressList(new Data(ai, false /*is_system_created*/));
+}
+
void AddressList::Append(const struct addrinfo* head) {
DCHECK(head);
// Always create a copy, since the Data might be shared across instances.
@@ -184,48 +226,6 @@ const struct addrinfo* AddressList::head() const {
AddressList::AddressList(Data* data) : data_(data) {}
-// static
-AddressList AddressList::CreateFromSockaddr(
- const struct sockaddr* address,
- socklen_t address_length,
- int socket_type,
- int protocol) {
- // Do sanity checking on socket_type and protocol.
- DCHECK(socket_type == SOCK_DGRAM || socket_type == SOCK_STREAM);
- DCHECK(protocol == IPPROTO_TCP || protocol == IPPROTO_UDP);
-
- struct addrinfo* ai = new addrinfo;
- memset(ai, 0, sizeof(addrinfo));
- switch (address_length) {
- case sizeof(struct sockaddr_in):
- {
- const struct sockaddr_in* sin =
- reinterpret_cast<const struct sockaddr_in*>(address);
- ai->ai_family = sin->sin_family;
- DCHECK_EQ(AF_INET, ai->ai_family);
- }
- break;
- case sizeof(struct sockaddr_in6):
- {
- const struct sockaddr_in6* sin6 =
- reinterpret_cast<const struct sockaddr_in6*>(address);
- ai->ai_family = sin6->sin6_family;
- DCHECK_EQ(AF_INET6, ai->ai_family);
- }
- break;
- default:
- NOTREACHED() << "Bad IP address";
- break;
- }
- ai->ai_socktype = socket_type;
- ai->ai_protocol = protocol;
- ai->ai_addrlen = address_length;
- ai->ai_addr = reinterpret_cast<struct sockaddr*>(new char[address_length]);
- memcpy(ai->ai_addr, address, address_length);
- return AddressList(new Data(ai, false /*is_system_created*/));
-}
-
-
AddressList::Data::Data(struct addrinfo* ai, bool is_system_created)
: head(ai), is_system_created(is_system_created) {
DCHECK(head);