diff options
| author | wtc@google.com <wtc@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-05 23:15:36 +0000 |
|---|---|---|
| committer | wtc@google.com <wtc@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-05 23:15:36 +0000 |
| commit | 836dff30efbff95f2090a024da25debe4edd2f83 (patch) | |
| tree | 9b07faaabad76f19a30769a9bdcd1ee5e3e47b2a /net/base/client_socket_factory.h | |
| parent | a218f15b205006e999a0dcabd7ebbe631def4e3b (diff) | |
| download | chromium_src-836dff30efbff95f2090a024da25debe4edd2f83.zip chromium_src-836dff30efbff95f2090a024da25debe4edd2f83.tar.gz chromium_src-836dff30efbff95f2090a024da25debe4edd2f83.tar.bz2 | |
Make some changes from my code review. Two significant
changes are:
1. Call WSAEventSelect before connect to fix a race
condition.
2. Call WSAResetEvent before WSARecv and WSASend because
the event is manual-reset and WSAGetOverlappedResult
doesn't reset the event for us.
R=darin
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@406 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/base/client_socket_factory.h')
| -rw-r--r-- | net/base/client_socket_factory.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/base/client_socket_factory.h b/net/base/client_socket_factory.h index 9a1b412..4115d74 100644 --- a/net/base/client_socket_factory.h +++ b/net/base/client_socket_factory.h @@ -41,6 +41,8 @@ class ClientSocket; // testing code with mock socket implementations. class ClientSocketFactory { public: + virtual ~ClientSocketFactory() {} + virtual ClientSocket* CreateTCPClientSocket( const AddressList& addresses) = 0; |