diff options
| author | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-16 00:34:13 +0000 |
|---|---|---|
| committer | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-16 00:34:13 +0000 |
| commit | bfb95f5dc2660a179c45066225a366b1ade2a81f (patch) | |
| tree | 735716697a61a87e9d63de26ea49bf9b32d1d7e7 /net/base/cookie_monster.h | |
| parent | 46c39f3ba687831eb0bdee81d7b893af50235110 (diff) | |
| download | chromium_src-bfb95f5dc2660a179c45066225a366b1ade2a81f.zip chromium_src-bfb95f5dc2660a179c45066225a366b1ade2a81f.tar.gz chromium_src-bfb95f5dc2660a179c45066225a366b1ade2a81f.tar.bz2 | |
Add some additional instrumention for bug 74585. It does the following:
(1) On Windows when the corruption is detected, prompts the user asking them to report it on http://crbug.com/74585.
This message is NOT internationalized, it is english only. But hopefully we will get some feedback from it.
(2) Before crashing, we do some additional checks in the map to see:
- how many pointers were NULL
- how many entries the map had
- dereference all the non-NULL values in the map to make sure they aren't garbage memory.
BUG=74585
Review URL: http://codereview.chromium.org/6693009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78310 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/base/cookie_monster.h')
| -rw-r--r-- | net/base/cookie_monster.h | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/net/base/cookie_monster.h b/net/base/cookie_monster.h index 0155735..b6649715 100644 --- a/net/base/cookie_monster.h +++ b/net/base/cookie_monster.h @@ -288,9 +288,13 @@ class CookieMonster : public CookieStore { DELETE_COOKIE_LAST_ENTRY }; - // Debugging method - // TODO(eroman): Delete this when 74585 is sorted out. + // Debugging methods + // TODO(eroman): Delete these when 74585 is sorted out. void ValidateMapWhileLockHeld(int arg); + static void CrashBecauseCookieMapIsInvalid( + const CookieMap& cookies, + const CookieMap::iterator& null_value_it, + int null_value_pos); // Cookie garbage collection thresholds. Based off of the Mozilla defaults. // When the number of cookies gets to k{Domain,}MaxCookies |