summaryrefslogtreecommitdiffstats
path: root/net/base/dnsrr_resolver_unittest.cc
diff options
context:
space:
mode:
authoragl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-08-18 20:04:12 +0000
committeragl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-08-18 20:04:12 +0000
commitff58b6b0e4a3774fb1e0b7c177529dc39651055b (patch)
treed9b1405f37a7ce4f6c7c527aeefcf5223237916e /net/base/dnsrr_resolver_unittest.cc
parent293f19251f23ea4c9de9c0d12262237e213ed788 (diff)
downloadchromium_src-ff58b6b0e4a3774fb1e0b7c177529dc39651055b.zip
chromium_src-ff58b6b0e4a3774fb1e0b7c177529dc39651055b.tar.gz
chromium_src-ff58b6b0e4a3774fb1e0b7c177529dc39651055b.tar.bz2
DnsRRResolver: hoist inner class and callback on MessageLoop.
This change moves the Response class to the top level to save other files from having to #include the header in order to get a pointer to a Response object. This change also modifies the semantics of resolution: the callback will now be made of the origin MessageLoop, rather than a random thread. TEST=net_unittests BUG=none http://codereview.chromium.org/3110015/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56585 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/base/dnsrr_resolver_unittest.cc')
-rw-r--r--net/base/dnsrr_resolver_unittest.cc8
1 files changed, 4 insertions, 4 deletions
diff --git a/net/base/dnsrr_resolver_unittest.cc b/net/base/dnsrr_resolver_unittest.cc
index 6e36126..23a0b40 100644
--- a/net/base/dnsrr_resolver_unittest.cc
+++ b/net/base/dnsrr_resolver_unittest.cc
@@ -52,7 +52,7 @@ class Rendezvous : public CallbackRunner<Tuple1<int> > {
// This test is disabled because it depends on the external network to pass.
// However, it may be useful when chaging the code.
TEST_F(DnsRRResolverTest, DISABLED_NetworkResolve) {
- DnsRRResolver::Response response;
+ RRResponse response;
Rendezvous callback;
ASSERT_TRUE(DnsRRResolver::Resolve(
"agl._pka.imperialviolet.org", kDNS_TXT, 0, &callback, &response));
@@ -111,7 +111,7 @@ static const uint8 kExamplePacket[] = {
};
TEST_F(DnsRRResolverTest, ParseExample) {
- DnsRRResolver::Response response;
+ RRResponse response;
ASSERT_TRUE(response.ParseFromResponse(kExamplePacket,
sizeof(kExamplePacket), kDNS_TXT));
ASSERT_EQ(1u, response.rrdatas.size());
@@ -124,7 +124,7 @@ TEST_F(DnsRRResolverTest, ParseExample) {
}
TEST_F(DnsRRResolverTest, FuzzTruncation) {
- DnsRRResolver::Response response;
+ RRResponse response;
for (unsigned len = sizeof(kExamplePacket); len <= sizeof(kExamplePacket);
len--) {
@@ -133,7 +133,7 @@ TEST_F(DnsRRResolverTest, FuzzTruncation) {
}
TEST_F(DnsRRResolverTest, FuzzCorruption) {
- DnsRRResolver::Response response;
+ RRResponse response;
uint8 copy[sizeof(kExamplePacket)];