diff options
| author | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-05 02:22:11 +0000 |
|---|---|---|
| committer | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-05 02:22:11 +0000 |
| commit | 780702c2aac603a5ca09c22e34d3f913a375627d (patch) | |
| tree | 9eec20da47f64859a072a8ca2ca03823953e5d52 /net/base/host_resolver_impl.cc | |
| parent | 8dc0234a8d2cec8bb1979ec8dec05bf23a79a42a (diff) | |
| download | chromium_src-780702c2aac603a5ca09c22e34d3f913a375627d.zip chromium_src-780702c2aac603a5ca09c22e34d3f913a375627d.tar.gz chromium_src-780702c2aac603a5ca09c22e34d3f913a375627d.tar.bz2 | |
Add one-time randomization support for FieldTrial, and the ability to
disable field trials. I am going to have a need for both soon.
Cleaning up some comments about empty trial names, adding static
method TrialExists() and simplifying many call sites by using this
method.
While I'm in there and needing base/OWNERS approval, add an OWNERS
file for base/metrics that adds jar@chromium.org as an owner for that
directory.
BUG=none
TEST=base_unittests
TBR=jam@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84197 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/base/host_resolver_impl.cc')
| -rw-r--r-- | net/base/host_resolver_impl.cc | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/net/base/host_resolver_impl.cc b/net/base/host_resolver_impl.cc index 8b33229..8c9d17f 100644 --- a/net/base/host_resolver_impl.cc +++ b/net/base/host_resolver_impl.cc @@ -554,9 +554,8 @@ class HostResolverImpl::Job UMA_HISTOGRAM_ENUMERATION("DNS.ResolveCategory", category, RESOLVE_MAX); - static bool show_speculative_experiment_histograms = - base::FieldTrialList::Find("DnsImpact") && - !base::FieldTrialList::Find("DnsImpact")->group_name().empty(); + static const bool show_speculative_experiment_histograms = + base::FieldTrialList::TrialExists("DnsImpact"); if (show_speculative_experiment_histograms) { UMA_HISTOGRAM_ENUMERATION( base::FieldTrial::MakeName("DNS.ResolveCategory", "DnsImpact"), @@ -566,9 +565,8 @@ class HostResolverImpl::Job "DnsImpact"), duration); } } - static bool show_parallelism_experiment_histograms = - base::FieldTrialList::Find("DnsParallelism") && - !base::FieldTrialList::Find("DnsParallelism")->group_name().empty(); + static const bool show_parallelism_experiment_histograms = + base::FieldTrialList::TrialExists("DnsParallelism"); if (show_parallelism_experiment_histograms) { UMA_HISTOGRAM_ENUMERATION( base::FieldTrial::MakeName("DNS.ResolveCategory", "DnsParallelism"), |