diff options
author | wtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-02 21:02:15 +0000 |
---|---|---|
committer | wtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-02 21:02:15 +0000 |
commit | cca8f4ae3d30e5fac962ee26538a6b2a06a2698c (patch) | |
tree | 0fe277334c557d81b50bf1008ddf12bbb1432465 /net/base/keygen_handler_unittest.cc | |
parent | bb64b5128f1641cba1e802ae7d0768be955ffdc5 (diff) | |
download | chromium_src-cca8f4ae3d30e5fac962ee26538a6b2a06a2698c.zip chromium_src-cca8f4ae3d30e5fac962ee26538a6b2a06a2698c.tar.gz chromium_src-cca8f4ae3d30e5fac962ee26538a6b2a06a2698c.tar.bz2 |
We should delete the underlying persistent public key only
when we cannot sign the challenge. This matches what Mozilla
does.
Fix nits.
R=snej
BUG=148
TEST=No compilation errors.
Review URL: http://codereview.chromium.org/1535016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43524 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/base/keygen_handler_unittest.cc')
-rw-r--r-- | net/base/keygen_handler_unittest.cc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/net/base/keygen_handler_unittest.cc b/net/base/keygen_handler_unittest.cc index d73d8e1..508508f 100644 --- a/net/base/keygen_handler_unittest.cc +++ b/net/base/keygen_handler_unittest.cc @@ -73,11 +73,11 @@ TEST(KeygenHandlerTest, Cache) { std::string key1("abcd"); cache->Insert(key1, location1); - // The cache should have stored location1 at key1 + // The cache should have stored location1 at key1. EXPECT_TRUE(cache->Find(key1, &location2)); // The cache should have retrieved it into location2, and their equality - // should be reflexive + // should be reflexive. EXPECT_TRUE(location1.Equals(location2)); EXPECT_TRUE(location2.Equals(location1)); @@ -85,11 +85,11 @@ TEST(KeygenHandlerTest, Cache) { KeygenHandler::KeyLocation location3 = ValidKeyLocation(); EXPECT_FALSE(location1.Equals(location2)); - // The cache should miss for an unregistered key + // The cache should miss for an unregistered key. std::string key2("def"); EXPECT_FALSE(cache->Find(key2, &location2)); - // A cache miss should leave the original location unmolested + // A cache miss should leave the original location unmolested. EXPECT_TRUE(location2.Equals(location3)); } |