diff options
| author | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-12 22:49:10 +0000 |
|---|---|---|
| committer | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-12 22:49:10 +0000 |
| commit | 562dbaec88e244316208d0df71262bc2461725dd (patch) | |
| tree | 70c39561713b1c9ee529c49703847a90b6aa88a3 /net/base/mock_host_resolver.cc | |
| parent | 4db3a01e07bc008b8a567c0735dbd813a49a617b (diff) | |
| download | chromium_src-562dbaec88e244316208d0df71262bc2461725dd.zip chromium_src-562dbaec88e244316208d0df71262bc2461725dd.tar.gz chromium_src-562dbaec88e244316208d0df71262bc2461725dd.tar.bz2 | |
Remove the unittest "DnsMasterTest.OsCachesLookupsTest".
This test was checking that the system host resolver maintains an internal cache, by doing actual DNS resolves (which introduces a network dependency in the unit tests). This could be flaky on linux, which doesn't cache resolves.
As of r18236 however, chromium maintains its own host cache. So the DNS prefetcher does not need to rely on the OS caching DNS resolves in order to be a win.
BUG=http://crbug.com/18766
Review URL: http://codereview.chromium.org/164350
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23239 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/base/mock_host_resolver.cc')
| -rw-r--r-- | net/base/mock_host_resolver.cc | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/net/base/mock_host_resolver.cc b/net/base/mock_host_resolver.cc index 32a66d1..eeabb39 100644 --- a/net/base/mock_host_resolver.cc +++ b/net/base/mock_host_resolver.cc @@ -165,11 +165,8 @@ int RuleBasedHostResolverProc::Resolve(const std::string& host, RuleList::iterator r; for (r = rules_.begin(); r != rules_.end(); ++r) { if (MatchPattern(host, r->host_pattern)) { - if (r->latency_ms != 0) { + if (r->latency_ms != 0) PlatformThread::Sleep(r->latency_ms); - // Hmm, this seems unecessary. - r->latency_ms = 1; - } // Remap to a new host. const std::string& effective_host = |