diff options
author | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-03 00:49:17 +0000 |
---|---|---|
committer | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-03 00:49:17 +0000 |
commit | 06650c582f9cfcf3869c490f3dc1ca224d6c9963 (patch) | |
tree | b6585569ec02f0bec32aa65b6e36b3cbf8a8533f /net/base/net_log.cc | |
parent | cb364d78210e5d64f3c899bbfa87dadebac7d6f7 (diff) | |
download | chromium_src-06650c582f9cfcf3869c490f3dc1ca224d6c9963.zip chromium_src-06650c582f9cfcf3869c490f3dc1ca224d6c9963.tar.gz chromium_src-06650c582f9cfcf3869c490f3dc1ca224d6c9963.tar.bz2 |
Rework the logging for sockets/connectjobs.
In particular, make it work better when using backup jobs / late binding (the display was very confused before because of how these asynchronous events would nest).
Also changed the paradigm for how PassiveLogCollector preserves these async associations -- this fixes how it replays the events to net-internals. (Before we would collapse the event streams into the SOURCE_URL_REQUEST which lost some hiearchy.. now I keep the separate streams).
Some of the particular changes to the event streams:
* ConnectJobs now create their own source stream internally.
* Sockets are now bounded by +SOCKET_ALIVE / -SOCKET_ALIVE events (removed the one-off SOCKET_DONE event).
* The socket log streams contains +SOCKET_IN_USE / -SOCKET_IN_USE event blocks to show which URLRequest was controlling it at various points in time (this makes it much easier to understand which read/writes belonged to a particular network transaction when a socket gets re-used).
* ConnectJobs are bounded by +SOCKET_POOL_CONNECT_JOB / - SOCKET_POOL_CONNECT_JOB events.
* ConnectJobs log the net error they failed with.
* Removed the SOCKET_BACKUP_TIMER_EXTENDED event.
Review URL: http://codereview.chromium.org/2363003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48797 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/base/net_log.cc')
-rw-r--r-- | net/base/net_log.cc | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/net/base/net_log.cc b/net/base/net_log.cc index 02b6bbd..ace4a53 100644 --- a/net/base/net_log.cc +++ b/net/base/net_log.cc @@ -97,4 +97,15 @@ Value* NetLogStringParameter::ToValue() const { return dict; } +Value* NetLogSourceParameter::ToValue() const { + DictionaryValue* dict = new DictionaryValue(); + + DictionaryValue* source_dict = new DictionaryValue(); + source_dict->SetInteger(L"type", static_cast<int>(value_.type)); + source_dict->SetInteger(L"id", static_cast<int>(value_.id)); + + dict->Set(ASCIIToWide(name_), source_dict); + return dict; +} + } // namespace net |