diff options
| author | grunell@chromium.org <grunell@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-05 14:13:13 +0000 |
|---|---|---|
| committer | grunell@chromium.org <grunell@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-05 14:13:13 +0000 |
| commit | bfcee29016c7af3ad5d054de3dd493b3c2196614 (patch) | |
| tree | 1484e7676a8edbeab84d65ef92afdead6eae920a /net/base/net_util_unittest.cc | |
| parent | c02f17969a0e04e7ca7abdb9fceddec0791bebe2 (diff) | |
| download | chromium_src-bfcee29016c7af3ad5d054de3dd493b3c2196614.zip chromium_src-bfcee29016c7af3ad5d054de3dd493b3c2196614.tar.gz chromium_src-bfcee29016c7af3ad5d054de3dd493b3c2196614.tar.bz2 | |
Improve network interface name on Win for WebRTC logs.
- Add |friendly_name| member to NetworkInterface struct. This will be the same as |name| on non-Windows. On Windows it will be FriendlyName in IP_ADAPTER_ADDRESSES.
- Use |friendly_name| in WebRTC logs.
- Add simple test in unit test for |friendly_name| not empty.
TBR=justinlin@chromium.org (trivial update in dial_service_unittest.cc)
BUG=347541
Review URL: https://codereview.chromium.org/185533006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255031 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/base/net_util_unittest.cc')
| -rw-r--r-- | net/base/net_util_unittest.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/base/net_util_unittest.cc b/net/base/net_util_unittest.cc index a0f466d..e62a644 100644 --- a/net/base/net_util_unittest.cc +++ b/net/base/net_util_unittest.cc @@ -3309,8 +3309,9 @@ TEST(NetUtilTest, GetNetworkList) { ASSERT_TRUE(GetNetworkList(&list, INCLUDE_HOST_SCOPE_VIRTUAL_INTERFACES)); for (NetworkInterfaceList::iterator it = list.begin(); it != list.end(); ++it) { - // Verify that the name is not empty. + // Verify that the names are not empty. EXPECT_FALSE(it->name.empty()); + EXPECT_FALSE(it->friendly_name.empty()); // Verify that the address is correct. EXPECT_TRUE(it->address.size() == kIPv4AddressSize || |