wtc: please look at URL related code, and hooks and nits

you might have commented on before.

huanr: please look at sdch_filter code.  The intent was
no semantic change, and only change in histograms and
stats gathered.  I wanted to be sure I had better stats
on several failure cases, as the turn-around time of
adding stats to instrument such cases after they surface
is just too long.

The big feature is the mechanism for getting the total
number of bytes passed to a filter.  We use the filter
context to achieve this, and then the SDCH filter can
calculate compression ratio (from pre-gunzip vs post
SDCH decompress).

The number of bytes read was also histogrammed in a number
of error scenarios, to better diagnose what is going on
when these cases arrise (example: When some data is still
buffered in the VCDIFF decoder).

The sdch_filter destructor was getting long and hard
to read with multiple if blocks, so I cleaned that up
as well a bit (less indentation, and use of early returns).

Nits not included in previous CL that earlier are listed
as well.

r=wtc,huanr
Review URL: http://codereview.chromium.org/40319

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11665 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 7 insertions, 3 deletions

diff --git a/net/base/sdch_manager.h b/net/base/sdch_manager.h
index e6ad7a0..3c585c3 100644
--- a/net/base/sdch_manager.h
+++ b/net/base/sdch_manager.h
@@ -119,7 +119,7 @@ class SdchManager {
     META_REFRESH_UNSUPPORTED = 74,         // Unrecoverable error.
     CACHED_META_REFRESH_UNSUPPORTED = 75,  // As above, but pulled from cache.
     PASSING_THROUGH_NON_SDCH = 76,  // Non-html tagged as sdch but malformed.
-    INCOMPLETE_SDCH_CONTENT = 77,  // Last window was not completely decoded.
+    INCOMPLETE_SDCH_CONTENT = 77,   // Last window was not completely decoded.
 
 
     // Common decoded recovery methods.
@@ -130,9 +130,13 @@ class SdchManager {
     // (i.e., be able to be sure all dictionary advertisements are accounted
     // for).
 
-    UNFLUSHED_CONTENT = 90,  // Possible error in filter chaining.
+    UNFLUSHED_CONTENT = 90,   // Possible error in filter chaining.
     MISSING_TIME_STATS = 91,  // Should never happen.
-    CACHE_DECODED = 92,  // Hence there are no timing stats recorded.
+    CACHE_DECODED = 92,       // No timing stats recorded.
+    OVER_10_MINUTES = 93,     // No timing stats will be recorded.
+    UNINITIALIZED = 94,       // Filter never even got initialized.
+    PRIOR_TO_DICTIONARY = 95, // We hadn't even parsed a dictionary selector.
+    DECODE_ERROR = 96,        // Something went wrong during decode.
 
     MAX_PROBLEM_CODE  // Used to bound histogram.
   };