diff options
| author | ericroman@google.com <ericroman@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-12 00:49:38 +0000 |
|---|---|---|
| committer | ericroman@google.com <ericroman@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-12 00:49:38 +0000 |
| commit | 8a00f00ab5d68ffcc998fd04d2ca343af7cdf190 (patch) | |
| tree | fd464ba49db4271c76c1cf8f769a22120ad631af /net/base/tcp_client_socket_pool_unittest.cc | |
| parent | 77ae132c1bfdd986228b6f1c0d8c63baa441afdf (diff) | |
| download | chromium_src-8a00f00ab5d68ffcc998fd04d2ca343af7cdf190.zip chromium_src-8a00f00ab5d68ffcc998fd04d2ca343af7cdf190.tar.gz chromium_src-8a00f00ab5d68ffcc998fd04d2ca343af7cdf190.tar.bz2 | |
* Avoid doing concurrent DNS resolves of the same hostname in HostResolver.
* Add a 1 minute cache for host resolves.
* Refactor HostResolver to handle multiple requests.
* Make HostResolver a dependency of URLRequestContext. operate the HostResolver
in async mode for proxy resolver (bridging to IO thread).
TEST=unittests
BUG=13163
Review URL: http://codereview.chromium.org/118100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18236 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/base/tcp_client_socket_pool_unittest.cc')
| -rw-r--r-- | net/base/tcp_client_socket_pool_unittest.cc | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/net/base/tcp_client_socket_pool_unittest.cc b/net/base/tcp_client_socket_pool_unittest.cc index ce85871..2073497 100644 --- a/net/base/tcp_client_socket_pool_unittest.cc +++ b/net/base/tcp_client_socket_pool_unittest.cc @@ -198,13 +198,19 @@ int TestSocketRequest::completion_count = 0; class TCPClientSocketPoolTest : public testing::Test { protected: TCPClientSocketPoolTest() - : pool_(new TCPClientSocketPool(kMaxSocketsPerGroup, + // We disable caching here since these unit tests don't expect + // host resolving to be able to complete synchronously. + // TODO(eroman): enable caching. + : host_resolver_(0, 0), + pool_(new TCPClientSocketPool(kMaxSocketsPerGroup, + &host_resolver_, &client_socket_factory_)) {} virtual void SetUp() { TestSocketRequest::completion_count = 0; } + HostResolver host_resolver_; MockClientSocketFactory client_socket_factory_; scoped_refptr<ClientSocketPool> pool_; std::vector<TestSocketRequest*> request_order_; |