summaryrefslogtreecommitdiffstats
path: root/net/base/x509_certificate_mac.cc
diff options
context:
space:
mode:
authorwtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-06-11 01:33:28 +0000
committerwtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-06-11 01:33:28 +0000
commitbdf652c4c18e00accc8f478ee2787ad09e6e424c (patch)
treeab7e2ab54e8c02200d75ed8c0b16c82a77591b17 /net/base/x509_certificate_mac.cc
parent428f02397724cc8508e3983c58752efd5d337851 (diff)
downloadchromium_src-bdf652c4c18e00accc8f478ee2787ad09e6e424c.zip
chromium_src-bdf652c4c18e00accc8f478ee2787ad09e6e424c.tar.gz
chromium_src-bdf652c4c18e00accc8f478ee2787ad09e6e424c.tar.bz2
Add LOG(WARNING) messages to track down where we set CERT_STATUS_INVALID.
R=rsleevi@chromium.org BUG=81005,85328 TEST=none Review URL: http://codereview.chromium.org/7134030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88754 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/base/x509_certificate_mac.cc')
-rw-r--r--net/base/x509_certificate_mac.cc12
1 files changed, 11 insertions, 1 deletions
diff --git a/net/base/x509_certificate_mac.cc b/net/base/x509_certificate_mac.cc
index 3b51777..84bf2fe 100644
--- a/net/base/x509_certificate_mac.cc
+++ b/net/base/x509_certificate_mac.cc
@@ -101,6 +101,8 @@ int CertStatusFromOSStatus(OSStatus status) {
// Failure was due to something Chromium doesn't define a
// specific status for (such as basic constraints violation, or
// unknown critical extension)
+ LOG(WARNING) << "Unknown error " << status
+ << " mapped to CERT_STATUS_INVALID";
return CERT_STATUS_INVALID;
}
}
@@ -948,6 +950,11 @@ int X509Certificate::Verify(const std::string& hostname, int flags,
if (chain_info[index].StatusBits & CSSM_CERT_STATUS_EXPIRED ||
chain_info[index].StatusBits & CSSM_CERT_STATUS_NOT_VALID_YET)
verify_result->cert_status |= CERT_STATUS_DATE_INVALID;
+ if (chain_info[index].NumStatusCodes == 0) {
+ LOG(WARNING) << "chain_info[" << index << "].NumStatusCodes is 0"
+ ", chain_info[" << index << "].StatusBits is "
+ << chain_info[index].StatusBits;
+ }
for (uint32 status_code_index = 0;
status_code_index < chain_info[index].NumStatusCodes;
++status_code_index) {
@@ -969,6 +976,7 @@ int X509Certificate::Verify(const std::string& hostname, int flags,
// is not trusted and the loop through CSSM_TP_APPLE_EVIDENCE_INFO
// should pick up everything else, but let's be safe.
if (!verify_result->cert_status && !got_certificate_error) {
+ LOG(ERROR) << "cssm_result=" << cssm_result;
verify_result->cert_status |= CERT_STATUS_INVALID;
NOTREACHED();
}
@@ -979,8 +987,10 @@ int X509Certificate::Verify(const std::string& hostname, int flags,
if (status)
return NetErrorFromOSStatus(status);
verify_result->cert_status |= CertStatusFromOSStatus(cssm_result);
- if (!verify_result->cert_status)
+ if (!verify_result->cert_status) {
+ LOG(WARNING) << "trust_result=" << trust_result;
verify_result->cert_status |= CERT_STATUS_INVALID;
+ }
break;
}