summaryrefslogtreecommitdiffstats
path: root/net/base
diff options
context:
space:
mode:
authorjrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-06-19 18:27:59 +0000
committerjrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-06-19 18:27:59 +0000
commit3016ded488e02efd8ba4b5a25044f1e726bb5995 (patch)
tree0a4dfc6a1d092b1a65c60589e6c138892bb40522 /net/base
parentf36fa4fb51ae8a8b1ccf6871c155700625e599f8 (diff)
downloadchromium_src-3016ded488e02efd8ba4b5a25044f1e726bb5995.zip
chromium_src-3016ded488e02efd8ba4b5a25044f1e726bb5995.tar.gz
chromium_src-3016ded488e02efd8ba4b5a25044f1e726bb5995.tar.bz2
Comments added to SSL unit tests.
Review URL: http://codereview.chromium.org/132081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18835 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/base')
-rw-r--r--net/base/ssl_client_socket_unittest.cc12
1 files changed, 12 insertions, 0 deletions
diff --git a/net/base/ssl_client_socket_unittest.cc b/net/base/ssl_client_socket_unittest.cc
index ef308a1..2d764e9 100644
--- a/net/base/ssl_client_socket_unittest.cc
+++ b/net/base/ssl_client_socket_unittest.cc
@@ -54,6 +54,18 @@ class SSLClientSocketTest : public PlatformTest {
//-----------------------------------------------------------------------------
#if defined(OS_MACOSX)
+// Status 6/19/09:
+//
+// If these tests are enabled on OSX, we choke at the point
+// SSLHandshake() (Security framework call) is called from
+// SSLClientSocketMac::DoHandshake(). Return value is -9812 (cert
+// valid but root not trusted), but if you don't have the cert in your
+// keychain as documented on
+// http://dev.chromium.org/developers/testing, the -9812 becomes a
+// -9813 (no root cert).
+//
+// See related handshake failures exhibited by disabled tests in
+// net/url_request/url_request_unittest.cc.
#define MAYBE_Connect DISABLED_Connect
#define MAYBE_ConnectExpired DISABLED_ConnectExpired
#define MAYBE_ConnectMismatched DISABLED_ConnectMismatched