diff options
| author | mbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-25 20:21:16 +0000 |
|---|---|---|
| committer | mbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-25 20:21:16 +0000 |
| commit | bd635c097dfc689674d6b21c006850a7b07f23f4 (patch) | |
| tree | b9c8bdf9edc379e288c14f64e063e29efe7635c8 /net/base | |
| parent | 19dc5d7922dc07b61c037ebbcc86f20dad27eab2 (diff) | |
| download | chromium_src-bd635c097dfc689674d6b21c006850a7b07f23f4.zip chromium_src-bd635c097dfc689674d6b21c006850a7b07f23f4.tar.gz chromium_src-bd635c097dfc689674d6b21c006850a7b07f23f4.tar.bz2 | |
Enable warning 4389 as an error on windows builds. This will make
windows builds more similar to linux/mac, which already treat signed/
unsigned equality comparisons as warnings (and hence errors).
BUG=44471
TEST=none
Review URL: http://codereview.chromium.org/2081007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48186 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/base')
| -rw-r--r-- | net/base/listen_socket_unittest.cc | 4 | ||||
| -rw-r--r-- | net/base/network_change_notifier_win.cc | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/net/base/listen_socket_unittest.cc b/net/base/listen_socket_unittest.cc index eb224c3..ed2b566 100644 --- a/net/base/listen_socket_unittest.cc +++ b/net/base/listen_socket_unittest.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -54,7 +54,7 @@ void ListenSocketTester::SetUp() { // verify the connect/accept and setup test_socket_ test_socket_ = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP); - ASSERT_NE(-1, test_socket_); + ASSERT_NE(INVALID_SOCKET, test_socket_); struct sockaddr_in client; client.sin_family = AF_INET; client.sin_addr.s_addr = inet_addr(kLoopback); diff --git a/net/base/network_change_notifier_win.cc b/net/base/network_change_notifier_win.cc index 8ae39fb..02b1834 100644 --- a/net/base/network_change_notifier_win.cc +++ b/net/base/network_change_notifier_win.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -51,7 +51,7 @@ NetworkChangeNotifierWin::Impl::~Impl() { void NetworkChangeNotifierWin::Impl::WatchForAddressChange() { HANDLE handle = NULL; DWORD ret = NotifyAddrChange(&handle, &addr_overlapped_); - CHECK_EQ(ERROR_IO_PENDING, ret); + CHECK(ret == ERROR_IO_PENDING); addr_watcher_.StartWatching(addr_overlapped_.hEvent, this); } |