summaryrefslogtreecommitdiffstats
path: root/net/base
diff options
context:
space:
mode:
authorjrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-01-26 00:33:23 +0000
committerjrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-01-26 00:33:23 +0000
commitb34a31b09919c02f620efe9974ff02f919778f78 (patch)
treee5683e1d0453e769453407bc2d592450d706b6ba /net/base
parente632190dd5dfe277d36c6bc58222b35890d94e88 (diff)
downloadchromium_src-b34a31b09919c02f620efe9974ff02f919778f78.zip
chromium_src-b34a31b09919c02f620efe9974ff02f919778f78.tar.gz
chromium_src-b34a31b09919c02f620efe9974ff02f919778f78.tar.bz2
Fix warnings (which are now errors) in the Android build.
BUG=None TEST= Review URL: http://codereview.chromium.org/9288034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119155 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/base')
-rw-r--r--net/base/address_list_unittest.cc4
-rw-r--r--net/base/host_resolver_impl_unittest.cc9
-rw-r--r--net/base/net_util.cc2
3 files changed, 9 insertions, 6 deletions
diff --git a/net/base/address_list_unittest.cc b/net/base/address_list_unittest.cc
index f34ffb5..3dda87a 100644
--- a/net/base/address_list_unittest.cc
+++ b/net/base/address_list_unittest.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -324,7 +324,7 @@ TEST(AddressListTest, CreateFromIPAddressList) {
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(tests); ++i) {
ASSERT_TRUE(next_ai != NULL);
EXPECT_EQ(tests[i].ai_family, next_ai->ai_family);
- EXPECT_EQ(tests[i].ai_addrlen, next_ai->ai_addrlen);
+ EXPECT_EQ(tests[i].ai_addrlen, static_cast<size_t>(next_ai->ai_addrlen));
char* ai_addr = reinterpret_cast<char*>(next_ai->ai_addr);
int rv = memcmp(tests[i].in_addr,
diff --git a/net/base/host_resolver_impl_unittest.cc b/net/base/host_resolver_impl_unittest.cc
index af9adc8..7acf244 100644
--- a/net/base/host_resolver_impl_unittest.cc
+++ b/net/base/host_resolver_impl_unittest.cc
@@ -394,7 +394,7 @@ TEST_F(HostResolverImplTest, AsynchronousLookup) {
const struct addrinfo* ainfo = addrlist.head();
EXPECT_EQ(static_cast<addrinfo*>(NULL), ainfo->ai_next);
- EXPECT_EQ(sizeof(struct sockaddr_in), ainfo->ai_addrlen);
+ EXPECT_EQ(sizeof(struct sockaddr_in), static_cast<size_t>(ainfo->ai_addrlen));
const struct sockaddr* sa = ainfo->ai_addr;
const struct sockaddr_in* sa_in = (const struct sockaddr_in*) sa;
@@ -564,7 +564,7 @@ TEST_F(HostResolverImplTest, NumericIPv4Address) {
const struct addrinfo* ainfo = addrlist.head();
EXPECT_EQ(static_cast<addrinfo*>(NULL), ainfo->ai_next);
- EXPECT_EQ(sizeof(struct sockaddr_in), ainfo->ai_addrlen);
+ EXPECT_EQ(sizeof(struct sockaddr_in), static_cast<size_t>(ainfo->ai_addrlen));
const struct sockaddr* sa = ainfo->ai_addr;
const struct sockaddr_in* sa_in = (const struct sockaddr_in*) sa;
@@ -591,7 +591,8 @@ TEST_F(HostResolverImplTest, NumericIPv6Address) {
const struct addrinfo* ainfo = addrlist.head();
EXPECT_EQ(static_cast<addrinfo*>(NULL), ainfo->ai_next);
- EXPECT_EQ(sizeof(struct sockaddr_in6), ainfo->ai_addrlen);
+ EXPECT_EQ(sizeof(struct sockaddr_in6),
+ static_cast<size_t>(ainfo->ai_addrlen));
const struct sockaddr* sa = ainfo->ai_addr;
const struct sockaddr_in6* sa_in6 = (const struct sockaddr_in6*) sa;
@@ -1552,7 +1553,7 @@ TEST_F(HostResolverImplTest, DisallowNonCachedResponses) {
const struct addrinfo* ainfo = addrlist.head();
EXPECT_EQ(static_cast<addrinfo*>(NULL), ainfo->ai_next);
- EXPECT_EQ(sizeof(struct sockaddr_in), ainfo->ai_addrlen);
+ EXPECT_EQ(sizeof(struct sockaddr_in), static_cast<size_t>(ainfo->ai_addrlen));
const struct sockaddr* sa = ainfo->ai_addr;
const struct sockaddr_in* sa_in = reinterpret_cast<const sockaddr_in*>(sa);
diff --git a/net/base/net_util.cc b/net/base/net_util.cc
index 05115c9..b4f1e579 100644
--- a/net/base/net_util.cc
+++ b/net/base/net_util.cc
@@ -2041,6 +2041,8 @@ bool IPv6Supported() {
// Another approach is implementing the similar feature by
// java.net.NetworkInterface through JNI.
NOTIMPLEMENTED();
+ // so we don't get a 'defined but not used' warning/err
+ IPv6SupportResults(IPV6_GETIFADDRS_FAILED);
return true;
#elif defined(OS_POSIX)
int test_socket = socket(AF_INET6, SOCK_STREAM, 0);