summaryrefslogtreecommitdiffstats
path: root/net/base
diff options
context:
space:
mode:
authorszym@chromium.org <szym@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-01-26 00:03:59 +0000
committerszym@chromium.org <szym@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-01-26 00:03:59 +0000
commitd0d49dd80ebcb6c7ca6b8e793a41866b4ad50eda (patch)
tree2eaa08ef3693d86bced45af389742ce3b6cee920 /net/base
parent0a87909ee992e63975a5e81b9dde328f2740921b (diff)
downloadchromium_src-d0d49dd80ebcb6c7ca6b8e793a41866b4ad50eda.zip
chromium_src-d0d49dd80ebcb6c7ca6b8e793a41866b4ad50eda.tar.gz
chromium_src-d0d49dd80ebcb6c7ca6b8e793a41866b4ad50eda.tar.bz2
DnsClient refactoring + features (timeout, suffix search, server rotation).
DnsClient::Request ==> DnsTransaction DnsTransaction ==> DnsTransactionImpl DnsClient ==> DnsTransactionFactory BUG=109949 TEST=net_unittests --gtest_filter=Dns* Review URL: http://codereview.chromium.org/9190031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119146 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/base')
-rw-r--r--net/base/dns_util.h5
-rw-r--r--net/base/net_log_event_type_list.h40
2 files changed, 34 insertions, 11 deletions
diff --git a/net/base/dns_util.h b/net/base/dns_util.h
index 03b1871..edfe559 100644
--- a/net/base/dns_util.h
+++ b/net/base/dns_util.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -22,7 +22,8 @@ namespace net {
NET_EXPORT_PRIVATE bool DNSDomainFromDot(const base::StringPiece& dotted,
std::string* out);
-// DNSDomainToString coverts a domain in DNS format to a dotted string.
+// DNSDomainToString converts a domain in DNS format to a dotted string.
+// Excludes the dot at the end.
NET_EXPORT_PRIVATE std::string DNSDomainToString(
const base::StringPiece& domain);
diff --git a/net/base/net_log_event_type_list.h b/net/base/net_log_event_type_list.h
index 2c27336..44f6f22 100644
--- a/net/base/net_log_event_type_list.h
+++ b/net/base/net_log_event_type_list.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -1205,7 +1205,6 @@ EVENT_TYPE(THROTTLING_GOT_CUSTOM_RETRY_AFTER)
// The BEGIN phase contains the following parameters:
//
// {
-// "dns_server": <IP of the DNS server to which queries are sent>,
// "hostname": <The hostname it is trying to resolve>,
// "query_type": <Type of the query>,
// "source_dependency": <Source id, if any, of what created the
@@ -1215,23 +1214,46 @@ EVENT_TYPE(THROTTLING_GOT_CUSTOM_RETRY_AFTER)
// The END phase contains the following parameters:
//
// {
-// "ip_address_list": <The result of the resolution process,
-// an IPAddressList>
// "net_error": <The net error code for the failure, if any>,
// }
EVENT_TYPE(DNS_TRANSACTION)
+// The start/end of a DnsTransaction query for a fully-qualified domain name.
+//
+// The BEGIN phase contains the following parameters:
+//
+// {
+// "qname": <The fully-qualified domain name it is trying to resolve>,
+// }
+//
+// The END phase contains the following parameters:
+//
+// {
+// "net_error": <The net error code for the failure, if any>,
+// }
+EVENT_TYPE(DNS_TRANSACTION_QUERY)
+
// This event is created when DnsTransaction creates a new UDP socket and
-// tries to resolve the hostname.
+// tries to resolve the fully-qualified name.
//
// It has a single parameter:
//
// {
-// "attempt_number": <current attempt number at resolving hostname>
-// "source_dependency": <Source id of the UDP socket that caused the
-// attempt>,
+// "socket_source": <Source id of the UDP socket created for the attempt>,
+// }
+EVENT_TYPE(DNS_TRANSACTION_ATTEMPT)
+
+// This event is created when DnsTransaction receives a matching response.
+//
+// It has the following parameters:
+//
+// {
+// "rcode": <rcode in the received response>,
+// "answer_count": <answer_count in the received response>,
+// "socket_source": <Source id of the UDP socket that received the
+// response>,
// }
-EVENT_TYPE(DNS_TRANSACTION_ATTEMPT_STARTED)
+EVENT_TYPE(DNS_TRANSACTION_RESPONSE)
// ------------------------------------------------------------------------
// AsyncHostResolver