diff options
| author | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-19 19:14:00 +0000 |
|---|---|---|
| committer | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-19 19:14:00 +0000 |
| commit | 1e43b6816aee7f20d12ec61b69bc05fe1dc0d449 (patch) | |
| tree | 798aff06960e2f6502b8295de360c7e645d10850 /net/base | |
| parent | da35960ef9fc0bfb80a6ef6306287e6241770239 (diff) | |
| download | chromium_src-1e43b6816aee7f20d12ec61b69bc05fe1dc0d449.zip chromium_src-1e43b6816aee7f20d12ec61b69bc05fe1dc0d449.tar.gz chromium_src-1e43b6816aee7f20d12ec61b69bc05fe1dc0d449.tar.bz2 | |
net: Fix more clang warnings about missing virtual and OVERRIDE annotations.
BUG=115047
R=willchan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10825437
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152296 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/base')
| -rw-r--r-- | net/base/dns_reloader.cc | 2 | ||||
| -rw-r--r-- | net/base/net_util.cc | 4 | ||||
| -rw-r--r-- | net/base/network_change_notifier.cc | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/net/base/dns_reloader.cc b/net/base/dns_reloader.cc index f0a57e6..f90c464 100644 --- a/net/base/dns_reloader.cc +++ b/net/base/dns_reloader.cc @@ -84,7 +84,7 @@ class DnsReloader : public net::NetworkChangeNotifier::DNSObserver { net::NetworkChangeNotifier::AddDNSObserver(this); } - ~DnsReloader() { + virtual ~DnsReloader() { NOTREACHED(); // LeakyLazyInstance is not destructed. } diff --git a/net/base/net_util.cc b/net/base/net_util.cc index d39d7ab..40c734f 100644 --- a/net/base/net_util.cc +++ b/net/base/net_util.cc @@ -836,7 +836,7 @@ class HostComponentTransform : public AppendComponentTransform { private: virtual string16 Execute( const std::string& component_text, - std::vector<size_t>* offsets_into_component) const { + std::vector<size_t>* offsets_into_component) const OVERRIDE { return IDNToUnicodeWithOffsets(component_text, languages_, offsets_into_component); } @@ -853,7 +853,7 @@ class NonHostComponentTransform : public AppendComponentTransform { private: virtual string16 Execute( const std::string& component_text, - std::vector<size_t>* offsets_into_component) const { + std::vector<size_t>* offsets_into_component) const OVERRIDE { return (unescape_rules_ == UnescapeRule::NONE) ? UTF8ToUTF16AndAdjustOffsets(component_text, offsets_into_component) : UnescapeAndDecodeUTF8URLComponentWithOffsets(component_text, diff --git a/net/base/network_change_notifier.cc b/net/base/network_change_notifier.cc index fa0ad77..3f66b45 100644 --- a/net/base/network_change_notifier.cc +++ b/net/base/network_change_notifier.cc @@ -31,7 +31,7 @@ NetworkChangeNotifierFactory* g_network_change_notifier_factory = NULL; class MockNetworkChangeNotifier : public NetworkChangeNotifier { public: - virtual ConnectionType GetCurrentConnectionType() const { + virtual ConnectionType GetCurrentConnectionType() const OVERRIDE { return CONNECTION_UNKNOWN; } }; |