diff options
author | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-28 09:29:28 +0000 |
---|---|---|
committer | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-28 09:29:28 +0000 |
commit | a981330295415845ef13cd85afeff42032d782df (patch) | |
tree | 46ad72c4cabd094a5f4dea2faa1bde6fb7d3677f /net/cookies/cookie_monster_store_test.cc | |
parent | 20eef6d14fce11a57949d052db064e56242c4c82 (diff) | |
download | chromium_src-a981330295415845ef13cd85afeff42032d782df.zip chromium_src-a981330295415845ef13cd85afeff42032d782df.tar.gz chromium_src-a981330295415845ef13cd85afeff42032d782df.tar.bz2 |
RefCounted types should not have public destructors, net/
BUG=123295
TEST=none
Review URL: http://codereview.chromium.org/10066045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134460 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/cookies/cookie_monster_store_test.cc')
-rw-r--r-- | net/cookies/cookie_monster_store_test.cc | 35 |
1 files changed, 18 insertions, 17 deletions
diff --git a/net/cookies/cookie_monster_store_test.cc b/net/cookies/cookie_monster_store_test.cc index 822aacc..f347e8d 100644 --- a/net/cookies/cookie_monster_store_test.cc +++ b/net/cookies/cookie_monster_store_test.cc @@ -25,8 +25,6 @@ MockPersistentCookieStore::MockPersistentCookieStore() loaded_(false) { } -MockPersistentCookieStore::~MockPersistentCookieStore() {} - void MockPersistentCookieStore::SetLoadExpectation( bool return_value, const std::vector<CookieMonster::CanonicalCookie*>& result) { @@ -85,6 +83,8 @@ void MockPersistentCookieStore::SetClearLocalStateOnExit(bool clear_local_state) { } +MockPersistentCookieStore::~MockPersistentCookieStore() {} + MockCookieMonsterDelegate::MockCookieMonsterDelegate() {} void MockCookieMonsterDelegate::OnCookieChanged( @@ -97,18 +97,6 @@ void MockCookieMonsterDelegate::OnCookieChanged( MockCookieMonsterDelegate::~MockCookieMonsterDelegate() {} -void AddCookieToList( - const std::string& key, - const std::string& cookie_line, - const base::Time& creation_time, - std::vector<CookieMonster::CanonicalCookie*>* out_list) { - scoped_ptr<CookieMonster::CanonicalCookie> cookie( - new CookieMonster::CanonicalCookie( - BuildCanonicalCookie(key, cookie_line, creation_time))); - - out_list->push_back(cookie.release()); -} - CookieMonster::CanonicalCookie BuildCanonicalCookie( const std::string& key, const std::string& cookie_line, @@ -135,10 +123,21 @@ CookieMonster::CanonicalCookie BuildCanonicalCookie( !cookie_expires.is_null(), !cookie_expires.is_null()); } -MockSimplePersistentCookieStore::MockSimplePersistentCookieStore() - : loaded_(false) {} +void AddCookieToList( + const std::string& key, + const std::string& cookie_line, + const base::Time& creation_time, + std::vector<CookieMonster::CanonicalCookie*>* out_list) { + scoped_ptr<CookieMonster::CanonicalCookie> cookie( + new CookieMonster::CanonicalCookie( + BuildCanonicalCookie(key, cookie_line, creation_time))); -MockSimplePersistentCookieStore::~MockSimplePersistentCookieStore() {} + out_list->push_back(cookie.release()); +} + +MockSimplePersistentCookieStore::MockSimplePersistentCookieStore() + : loaded_(false) { +} void MockSimplePersistentCookieStore::Load( const LoadedCallback& loaded_callback) { @@ -228,4 +227,6 @@ CookieMonster* CreateMonsterFromStoreForGC( return new CookieMonster(store, NULL); } +MockSimplePersistentCookieStore::~MockSimplePersistentCookieStore() {} + } // namespace net |