summaryrefslogtreecommitdiffstats
path: root/net/data
diff options
context:
space:
mode:
authorphajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-06-26 08:01:09 +0000
committerphajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-06-26 08:01:09 +0000
commit3e076bf848daaa9c4a22bff569e25e6292029f60 (patch)
tree7f8dba9c8073656852ab7e91c24e6eb622aee02e /net/data
parent22c966cde1eab5e2c25c295467b5a7549ab1324c (diff)
downloadchromium_src-3e076bf848daaa9c4a22bff569e25e6292029f60.zip
chromium_src-3e076bf848daaa9c4a22bff569e25e6292029f60.tar.gz
chromium_src-3e076bf848daaa9c4a22bff569e25e6292029f60.tar.bz2
Fix a renderer crash while processing FTP directory listing.
The problem was caused by a broken assumption about current_parser_. After adding OnEndOfInput to FtpDirectoryListingParser interface, it was possible that during processing of input we ended up with just one parser, which returned error when OnEndOfInput was called. In that case, we should just reset current_parser_ to NULL to avoid a use-after-free error. TEST=net_unittests BUG=47528 Review URL: http://codereview.chromium.org/2846037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50930 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/data')
-rw-r--r--net/data/ftp/dir-listing-ls-171
-rw-r--r--net/data/ftp/dir-listing-ls-17.expected0
2 files changed, 1 insertions, 0 deletions
diff --git a/net/data/ftp/dir-listing-ls-17 b/net/data/ftp/dir-listing-ls-17
new file mode 100644
index 0000000..c07fbf3
--- /dev/null
+++ b/net/data/ftp/dir-listing-ls-17
@@ -0,0 +1 @@
+ftpd-BSD: .: Permission denied
diff --git a/net/data/ftp/dir-listing-ls-17.expected b/net/data/ftp/dir-listing-ls-17.expected
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/net/data/ftp/dir-listing-ls-17.expected