diff options
| author | rvargas@google.com <rvargas@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-14 21:44:21 +0000 |
|---|---|---|
| committer | rvargas@google.com <rvargas@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-14 21:44:21 +0000 |
| commit | 9fe2076f8920c4af968496e71b069e24158147d9 (patch) | |
| tree | dfa80681e1a77cac81f6f02205e15d25b69eec8f /net/disk_cache/disk_cache.h | |
| parent | 98c975ee6c7fd14fcd6a7490930f609b727346ca (diff) | |
| download | chromium_src-9fe2076f8920c4af968496e71b069e24158147d9.zip chromium_src-9fe2076f8920c4af968496e71b069e24158147d9.tar.gz chromium_src-9fe2076f8920c4af968496e71b069e24158147d9.tar.bz2 | |
Disk cache: Improve the documentation related to proper use of enumerations.
BUG=168870
TEST=none
Review URL: https://codereview.chromium.org/11848003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176728 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/disk_cache/disk_cache.h')
| -rw-r--r-- | net/disk_cache/disk_cache.h | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/net/disk_cache/disk_cache.h b/net/disk_cache/disk_cache.h index 9eca63a..d2e01a0 100644 --- a/net/disk_cache/disk_cache.h +++ b/net/disk_cache/disk_cache.h @@ -127,7 +127,12 @@ class NET_EXPORT Backend { // remain valid until the operation completes. // // NOTE: This method does not modify the last_used field of the entry, and - // therefore it does not impact the eviction ranking of the entry. + // therefore it does not impact the eviction ranking of the entry. However, + // an enumeration will go through all entries on the cache only if the cache + // is not modified while the enumeration is taking place. Significantly + // altering the entry pointed by |iter| (for example, deleting the entry) will + // invalidate |iter|. Performing operations on an entry that modify the entry + // may result in loops in the iteration, skipped entries or similar. virtual int OpenNextEntry(void** iter, Entry** next_entry, const CompletionCallback& callback) = 0; |