Disk cache: Prevent obscure file corruption and deal

with the result of that corruption.

1. Now we mark any open entry as dirty, even if we are
supposed to delete the entry right away because if we
crash before that, we may end up clearing the dirty
flag of a dirty entry.

2. When we look for a parent of a given entry we now
double check that the entry is the one that we want (and
not just another entry with the same key).

3. If we have a loop on the hash collision list (result of
failing to do 1 and 2 above), we figure that out.

4. Now every time we open an entry from an LRU list we end
up using the same code path (with the proper handling of
dirty entries).

BUG=69135
TEST=net_unittests

Review URL: http://codereview.chromium.org/6292011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72563 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 5 insertions, 0 deletions

diff --git a/net/disk_cache/eviction.h b/net/disk_cache/eviction.h
index 0f5eeb7..26f88fe 100644
--- a/net/disk_cache/eviction.h
+++ b/net/disk_cache/eviction.h
@@ -40,6 +40,10 @@ class Eviction {
   void OnDoomEntry(EntryImpl* entry);
   void OnDestroyEntry(EntryImpl* entry);
 
+  // Testing interface.
+  void SetTestMode();
+  void TrimDeletedList(bool empty);
+
  private:
   void PostDelayedTrim();
   void DelayedTrim();
@@ -75,6 +79,7 @@ class Eviction {
   bool trimming_;
   bool delay_trim_;
   bool init_;
+  bool test_mode_;
   bool in_experiment_;
   ScopedRunnableMethodFactory<Eviction> factory_;