diff options
| author | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-06 00:09:37 +0000 |
|---|---|---|
| committer | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-06 00:09:37 +0000 |
| commit | e8829a1981a2d9d849c377c28f9444fdefee0f44 (patch) | |
| tree | 3cfe522cf76d308dec9fca773d3f9495e12abc5e /net/disk_cache/histogram_macros.h | |
| parent | 4f3b65a30cad88c1f1e482f7bda69ef50f8e1364 (diff) | |
| download | chromium_src-e8829a1981a2d9d849c377c28f9444fdefee0f44.zip chromium_src-e8829a1981a2d9d849c377c28f9444fdefee0f44.tar.gz chromium_src-e8829a1981a2d9d849c377c28f9444fdefee0f44.tar.bz2 | |
Use factory to create histograms, and refcounts to track lifetimes
This is CL patch 377028 by Raman Tenneti, with minor changes to
make the try-bots happier.
It is cleanup that better ensures lifetimes of histograms (making it harder
for users to abuse them).
bug=16495 (repairs leak induced by the first landing)
bug=18840 (should make leaks less possible)
tbr=raman.tenneti
Review URL: http://codereview.chromium.org/462027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33933 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/disk_cache/histogram_macros.h')
| -rw-r--r-- | net/disk_cache/histogram_macros.h | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/net/disk_cache/histogram_macros.h b/net/disk_cache/histogram_macros.h index 6ff66ea..6d63dc8 100644 --- a/net/disk_cache/histogram_macros.h +++ b/net/disk_cache/histogram_macros.h @@ -26,9 +26,11 @@ UMA_HISTOGRAM_TIMES(name, Time::Now() - initial_time) #define UMA_HISTOGRAM_CACHE_ERROR(name, sample) do { \ - static LinearHistogram counter((name), 0, 49, 50); \ - counter.SetFlags(kUmaTargetedHistogramFlag); \ - counter.Add(sample); \ + static scoped_refptr<Histogram> counter = \ + LinearHistogram::LinearHistogramFactoryGet(\ + (name), 1, 49, 50); \ + counter->SetFlags(kUmaTargetedHistogramFlag); \ + counter->Add(sample); \ } while (0) #ifdef NET_DISK_CACHE_BACKEND_IMPL_CC_ |