diff options
| author | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-05 06:22:24 +0000 |
|---|---|---|
| committer | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-05 06:22:24 +0000 |
| commit | 98359ce4f10e42fd1ff8cb50dbf8d26a1ce01fa5 (patch) | |
| tree | 910022474d4ac2ea2d4ef52de8cc07adca4cd634 /net/disk_cache/stats_histogram.h | |
| parent | bddae3106719d34c89a89736f26de1da762a0898 (diff) | |
| download | chromium_src-98359ce4f10e42fd1ff8cb50dbf8d26a1ce01fa5.zip chromium_src-98359ce4f10e42fd1ff8cb50dbf8d26a1ce01fa5.tar.gz chromium_src-98359ce4f10e42fd1ff8cb50dbf8d26a1ce01fa5.tar.bz2 | |
Reland code to detect corruption of histogram ranges
This code was reverted because it caused, or exposed
flakiness in sync unit test code (mostly on the Mac).
We need to monitor that closely as we re-land.
See the reviews and history in CLs:
http://codereview.chromium.org/6577013
and
http://codereview.chromium.org/6591052
This code generates CRC checksums for the histogram
bucket-range vectors, and guarantees they remain
intact when the histogram data is about to be
uploaded to UMA. If the data is corrupted, then
we will fail on a CHECK().
r=mbelshe,rvargas
bug=73939
Review URL: http://codereview.chromium.org/6627011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77033 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/disk_cache/stats_histogram.h')
| -rw-r--r-- | net/disk_cache/stats_histogram.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/disk_cache/stats_histogram.h b/net/disk_cache/stats_histogram.h index 499784c..249327c 100644 --- a/net/disk_cache/stats_histogram.h +++ b/net/disk_cache/stats_histogram.h @@ -45,6 +45,7 @@ class StatsHistogram : public base::Histogram { virtual size_t bucket_count() const; virtual void SnapshotSample(SampleSet* sample) const; virtual Inconsistencies FindCorruption(const SampleSet& snapshot) const; + virtual uint32 CalculateRangeChecksum() const; private: bool init_; |