diff options
| author | erikwright@chromium.org <erikwright@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-13 16:27:07 +0000 |
|---|---|---|
| committer | erikwright@chromium.org <erikwright@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-13 16:27:07 +0000 |
| commit | 0499e4d914f2e27b53bc5b4cdf3115c09b33eba3 (patch) | |
| tree | 441c3a6b6e10783a1d1459a08d65b2928c742a0a /net/dns | |
| parent | 5cb4287f6e7925bd7c3ae11e7a3836b76346892e (diff) | |
| download | chromium_src-0499e4d914f2e27b53bc5b4cdf3115c09b33eba3.zip chromium_src-0499e4d914f2e27b53bc5b4cdf3115c09b33eba3.tar.gz chromium_src-0499e4d914f2e27b53bc5b4cdf3115c09b33eba3.tar.bz2 | |
Don't attempt to forward declare StringPiece.
1) This is discouraged because it prevents callers from benefiting from automatic coersion from string/char* types.
2) A follow-up CL (http://codereview.chromium.org/8659047/) will make StringPiece a template, and thus awkward to forward declare. The very small number of places that were appropriately forward declaring it do not justify writing a 'string_piece_forward.h'.
BUG=87634
R=cbentzel@chromium.org
Review URL: http://codereview.chromium.org/8929002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114219 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/dns')
| -rw-r--r-- | net/dns/dns_client.h | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/net/dns/dns_client.h b/net/dns/dns_client.h index af75cf6..b2e3c0a 100644 --- a/net/dns/dns_client.h +++ b/net/dns/dns_client.h @@ -11,12 +11,9 @@ #include "base/basictypes.h" #include "base/callback.h" #include "base/memory/weak_ptr.h" +#include "base/string_piece.h" #include "net/base/net_export.h" -namespace base { -class StringPiece; -} - namespace net { class BoundNetLog; |