diff options
author | mbelshe@google.com <mbelshe@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-06 21:51:58 +0000 |
---|---|---|
committer | mbelshe@google.com <mbelshe@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-06 21:51:58 +0000 |
commit | 22eb9681c29d15336d3579b84f417c462d4e8667 (patch) | |
tree | 6ea564a84c3fa84970b21fe9bfd9d907d5df1a13 /net/flip/flip_session.h | |
parent | f770d0fb057c336eb7a573c5c1a887d366bcc7fc (diff) | |
download | chromium_src-22eb9681c29d15336d3579b84f417c462d4e8667.zip chromium_src-22eb9681c29d15336d3579b84f417c462d4e8667.tar.gz chromium_src-22eb9681c29d15336d3579b84f417c462d4e8667.tar.bz2 |
Take3:
Rework the FlipProtocol to separate the Clike structs from the
methods. Without this refactoring, we didn't have a clean way
to allocate and deallocate FlipFrames. Now we can use the
scoped_ptr cleanly.
Summary of misc changes:
* Merged in some small changes from the GFE side.
* flip_protocol.h Changes substantially. We now have separate
structs and classes. No longer can you cast from one frame
type to another. All FlipFrame classes derive from FlipFrame.
A FlipFrame owns a buffer which is used for the frame, and
when you create the Frame, you can specify whether the FlipFrame
will selfclean its buffer or not. This makes it cheap to
instantiate a FlipFrame class on the stack and use it temporarily
for accessing fields without having to do any copies or allocations.
* You can't use sizeof(FlipFrame) anymore that is now a class.
Added a static "size()" method to each FlipFrame type for
declaring its real size.
* Refactored a couple of routines in flip_framer. These were
previously in a huge state machine (ProcessInput), just copied
the code into subroutines.
* Added flip_protocol_test to the mix from the gfe side. Much of
this is a refactoring from flip_framer_test.
* Eliminated reinterpret_casts as much as I could and got rid of
all uses of scoped_array for FlipFrames.
BUG=none
TEST=all flip tests reworked
Review URL: http://codereview.chromium.org/377014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31305 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/flip/flip_session.h')
-rw-r--r-- | net/flip/flip_session.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/flip/flip_session.h b/net/flip/flip_session.h index a76630d..7c7ad78 100644 --- a/net/flip/flip_session.h +++ b/net/flip/flip_session.h @@ -143,7 +143,6 @@ class FlipSession : public base::RefCounted<FlipSession>, const char* data, size_t len); virtual void OnControl(const flip::FlipControlFrame* frame); - virtual void OnLameDuck(); // Control frame handlers. void OnSyn(const flip::FlipSynStreamControlFrame* frame, |