diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-10 17:17:41 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-10 17:17:41 +0000 |
| commit | 685f6cbb6e8ac88c41d178490ed18b1aea6cfba1 (patch) | |
| tree | ac4f9dffdb9db61439525ecf14c525f959849db7 /net/ftp/ftp_network_transaction.h | |
| parent | f439d53c11de91db1fa86a22b156e14b696f8adb (diff) | |
| download | chromium_src-685f6cbb6e8ac88c41d178490ed18b1aea6cfba1.zip chromium_src-685f6cbb6e8ac88c41d178490ed18b1aea6cfba1.tar.gz chromium_src-685f6cbb6e8ac88c41d178490ed18b1aea6cfba1.tar.bz2 | |
FTP: fix compatibility problems with MLSD by removing MLSD support.
Some FTP servers send MLSD listings with no facts, just
the file names. This is a valid RFC-3659 listing, but
is useless for web browsers.
In theory we could check whether a server advertises
MLSD support in FEAT response, or use LIST when MLSD
only returns file names, but the extra complexity
is not worth it.
All servers supporting MLSD must also support LIST,
so this should not regress compatibility.
This change also removes the "HPRC" directory listing parser.
Actually, it was just MLSD listing with no facts.
BUG=65328, 65584
TEST=net_unittests, also see the bugs
Review URL: http://codereview.chromium.org/5669001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68859 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/ftp/ftp_network_transaction.h')
| -rw-r--r-- | net/ftp/ftp_network_transaction.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/net/ftp/ftp_network_transaction.h b/net/ftp/ftp_network_transaction.h index 5bad335..678308a 100644 --- a/net/ftp/ftp_network_transaction.h +++ b/net/ftp/ftp_network_transaction.h @@ -58,7 +58,6 @@ class FtpNetworkTransaction : public FtpTransaction { COMMAND_SIZE, COMMAND_RETR, COMMAND_CWD, - COMMAND_MLSD, COMMAND_LIST, COMMAND_QUIT, }; @@ -142,8 +141,6 @@ class FtpNetworkTransaction : public FtpTransaction { int ProcessResponseSIZE(const FtpCtrlResponse& response); int DoCtrlWriteCWD(); int ProcessResponseCWD(const FtpCtrlResponse& response); - int DoCtrlWriteMLSD(); - int ProcessResponseMLSD(const FtpCtrlResponse& response); int DoCtrlWriteLIST(); int ProcessResponseLIST(const FtpCtrlResponse& response); int DoCtrlWriteQUIT(); @@ -234,7 +231,6 @@ class FtpNetworkTransaction : public FtpTransaction { STATE_CTRL_WRITE_RETR, STATE_CTRL_WRITE_SIZE, STATE_CTRL_WRITE_CWD, - STATE_CTRL_WRITE_MLSD, STATE_CTRL_WRITE_LIST, STATE_CTRL_WRITE_QUIT, // Data connection states: |