summaryrefslogtreecommitdiffstats
path: root/net/ftp
diff options
context:
space:
mode:
authorerg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2010-09-30 20:06:30 +0000
committererg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2010-09-30 20:06:30 +0000
commit20f0487a5b73e8071af2612150301b0942cbf0e2 (patch)
treeecee69b28f16712bdc1558ac0a015ac80095c761 /net/ftp
parent167b0dd17d5ed57ff293b6480ccaed706e0bc9cb (diff)
downloadchromium_src-20f0487a5b73e8071af2612150301b0942cbf0e2.zip
chromium_src-20f0487a5b73e8071af2612150301b0942cbf0e2.tar.gz
chromium_src-20f0487a5b73e8071af2612150301b0942cbf0e2.tar.bz2
FBTF: Move ctors/dtors into implementation files. Adds ctors/dtors to non-POD structs.
Cuts ~2MB off our .a files (Debug, Linux). Also added the "virtual" keyword on a whole bunch of virtual dtors that were missing it. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3522004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61100 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/ftp')
-rw-r--r--net/ftp/ftp_auth_cache.cc14
-rw-r--r--net/ftp/ftp_auth_cache.h11
2 files changed, 18 insertions, 7 deletions
diff --git a/net/ftp/ftp_auth_cache.cc b/net/ftp/ftp_auth_cache.cc
index caa2b8a..a67c2e0 100644
--- a/net/ftp/ftp_auth_cache.cc
+++ b/net/ftp/ftp_auth_cache.cc
@@ -12,6 +12,20 @@ namespace net {
// static
const size_t FtpAuthCache::kMaxEntries = 10;
+FtpAuthCache::Entry::Entry(const GURL& origin,
+ const string16& username,
+ const string16& password)
+ : origin(origin),
+ username(username),
+ password(password) {
+}
+
+FtpAuthCache::Entry::~Entry() {}
+
+FtpAuthCache::FtpAuthCache() {}
+
+FtpAuthCache::~FtpAuthCache() {}
+
FtpAuthCache::Entry* FtpAuthCache::Lookup(const GURL& origin) {
for (EntryList::iterator it = entries_.begin(); it != entries_.end(); ++it) {
if (it->origin == origin)
diff --git a/net/ftp/ftp_auth_cache.h b/net/ftp/ftp_auth_cache.h
index 36156da..f935fe9 100644
--- a/net/ftp/ftp_auth_cache.h
+++ b/net/ftp/ftp_auth_cache.h
@@ -28,19 +28,16 @@ class FtpAuthCache {
struct Entry {
Entry(const GURL& origin, const string16& username,
- const string16& password)
- : origin(origin),
- username(username),
- password(password) {
- }
+ const string16& password);
+ ~Entry();
const GURL origin;
string16 username;
string16 password;
};
- FtpAuthCache() {}
- ~FtpAuthCache() {}
+ FtpAuthCache();
+ ~FtpAuthCache();
// Return Entry corresponding to given |origin| or NULL if not found.
Entry* Lookup(const GURL& origin);