diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-12 09:53:55 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-12 09:53:55 +0000 |
| commit | ed1e2096b587e20bc3e1d6dd20576e9fc6228f90 (patch) | |
| tree | 6a170e4d514c0413741777d6fda79ec43f0cfe84 /net/ftp | |
| parent | f17805f59f76d2aa8221e0caf4a96360fcba16ae (diff) | |
| download | chromium_src-ed1e2096b587e20bc3e1d6dd20576e9fc6228f90.zip chromium_src-ed1e2096b587e20bc3e1d6dd20576e9fc6228f90.tar.gz chromium_src-ed1e2096b587e20bc3e1d6dd20576e9fc6228f90.tar.bz2 | |
Record more categories of errors for ftp data connection histograms.
The "other error" bucket gets too many hits.
TEST=none
BUG=3073
Review URL: http://codereview.chromium.org/547020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36002 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/ftp')
| -rw-r--r-- | net/ftp/ftp_network_transaction.cc | 23 |
1 files changed, 22 insertions, 1 deletions
diff --git a/net/ftp/ftp_network_transaction.cc b/net/ftp/ftp_network_transaction.cc index ec87b8c..1a7c67f 100644 --- a/net/ftp/ftp_network_transaction.cc +++ b/net/ftp/ftp_network_transaction.cc @@ -1174,6 +1174,15 @@ void FtpNetworkTransaction::RecordDataConnectionError(int result) { // Connection has been refused. NET_ERROR_CONNECTION_REFUSED = 4, + // No connection to the internet. + NET_ERROR_INTERNET_DISCONNECTED = 5, + + // Could not resolve the destination address. + NET_ERROR_ADDRESS_NOT_FOUND = 6, + + // A programming error in our network stack. + NET_ERROR_UNEXPECTED = 7, + // Other kind of error. NET_ERROR_OTHER = 20, @@ -1189,13 +1198,25 @@ void FtpNetworkTransaction::RecordDataConnectionError(int result) { case ERR_TIMED_OUT: type = NET_ERROR_TIMED_OUT; break; - case ERR_CONNECTION_RESET: case ERR_CONNECTION_ABORTED: + case ERR_CONNECTION_RESET: + case ERR_CONNECTION_CLOSED: type = NET_ERROR_CONNECTION_BROKEN; break; + case ERR_CONNECTION_FAILED: case ERR_CONNECTION_REFUSED: type = NET_ERROR_CONNECTION_REFUSED; break; + case ERR_INTERNET_DISCONNECTED: + type = NET_ERROR_INTERNET_DISCONNECTED; + break; + case ERR_ADDRESS_INVALID: + case ERR_ADDRESS_UNREACHABLE: + type = NET_ERROR_ADDRESS_NOT_FOUND; + break; + case ERR_UNEXPECTED: + type = NET_ERROR_UNEXPECTED; + break; default: type = NET_ERROR_OTHER; break; |