diff options
author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-01 20:38:10 +0000 |
---|---|---|
committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-01 20:38:10 +0000 |
commit | f1f3f0f8af3740ec2afaebcaed410950a9cc0ac8 (patch) | |
tree | 6ccdd87ccfc89adbcb372c517559fa61fbc6c6b2 /net/ftp | |
parent | d1666539b57bf8552e203d355fd09909d36f9732 (diff) | |
download | chromium_src-f1f3f0f8af3740ec2afaebcaed410950a9cc0ac8.zip chromium_src-f1f3f0f8af3740ec2afaebcaed410950a9cc0ac8.tar.gz chromium_src-f1f3f0f8af3740ec2afaebcaed410950a9cc0ac8.tar.bz2 |
Begin CompletionCallback switchover.
Rename CompletionCallback to OldCompletionCallback in preparation for introducing a new CompletionCallback based on base::Callback.
Also renames other CompletionCallback types like CancelableCompletionCallback and TestCompletionCallback and CompletionCallbackImpl. All using sed with s/CompletionCallback/OldCompletionCallback/g.
BUG=98719
TEST=none
Review URL: http://codereview.chromium.org/8070013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103650 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/ftp')
-rw-r--r-- | net/ftp/ftp_network_transaction.cc | 10 | ||||
-rw-r--r-- | net/ftp/ftp_network_transaction.h | 12 | ||||
-rw-r--r-- | net/ftp/ftp_network_transaction_unittest.cc | 2 | ||||
-rw-r--r-- | net/ftp/ftp_transaction.h | 12 |
4 files changed, 18 insertions, 18 deletions
diff --git a/net/ftp/ftp_network_transaction.cc b/net/ftp/ftp_network_transaction.cc index 4a3a413..56dd311 100644 --- a/net/ftp/ftp_network_transaction.cc +++ b/net/ftp/ftp_network_transaction.cc @@ -237,12 +237,12 @@ int FtpNetworkTransaction::Stop(int error) { } int FtpNetworkTransaction::RestartIgnoringLastError( - CompletionCallback* callback) { + OldCompletionCallback* callback) { return ERR_NOT_IMPLEMENTED; } int FtpNetworkTransaction::Start(const FtpRequestInfo* request_info, - CompletionCallback* callback, + OldCompletionCallback* callback, const BoundNetLog& net_log) { net_log_ = net_log; request_ = request_info; @@ -265,7 +265,7 @@ int FtpNetworkTransaction::Start(const FtpRequestInfo* request_info, int FtpNetworkTransaction::RestartWithAuth(const string16& username, const string16& password, - CompletionCallback* callback) { + OldCompletionCallback* callback) { ResetStateForRestart(); username_ = username; @@ -280,7 +280,7 @@ int FtpNetworkTransaction::RestartWithAuth(const string16& username, int FtpNetworkTransaction::Read(IOBuffer* buf, int buf_len, - CompletionCallback* callback) { + OldCompletionCallback* callback) { DCHECK(buf); DCHECK_GT(buf_len, 0); @@ -347,7 +347,7 @@ void FtpNetworkTransaction::DoCallback(int rv) { DCHECK(user_callback_); // Since Run may result in Read being called, clear callback_ up front. - CompletionCallback* c = user_callback_; + OldCompletionCallback* c = user_callback_; user_callback_ = NULL; c->Run(rv); } diff --git a/net/ftp/ftp_network_transaction.h b/net/ftp/ftp_network_transaction.h index a1637c2..cce5adb 100644 --- a/net/ftp/ftp_network_transaction.h +++ b/net/ftp/ftp_network_transaction.h @@ -34,16 +34,16 @@ class NET_EXPORT_PRIVATE FtpNetworkTransaction : public FtpTransaction { virtual ~FtpNetworkTransaction(); virtual int Stop(int error); - virtual int RestartIgnoringLastError(CompletionCallback* callback); + virtual int RestartIgnoringLastError(OldCompletionCallback* callback); // FtpTransaction methods: virtual int Start(const FtpRequestInfo* request_info, - CompletionCallback* callback, + OldCompletionCallback* callback, const BoundNetLog& net_log) OVERRIDE; virtual int RestartWithAuth(const string16& username, const string16& password, - CompletionCallback* callback) OVERRIDE; - virtual int Read(IOBuffer* buf, int buf_len, CompletionCallback* callback) + OldCompletionCallback* callback) OVERRIDE; + virtual int Read(IOBuffer* buf, int buf_len, OldCompletionCallback* callback) OVERRIDE; virtual const FtpResponseInfo* GetResponseInfo() const OVERRIDE; virtual LoadState GetLoadState() const OVERRIDE; @@ -190,8 +190,8 @@ class NET_EXPORT_PRIVATE FtpNetworkTransaction : public FtpTransaction { Command command_sent_; - CompletionCallbackImpl<FtpNetworkTransaction> io_callback_; - CompletionCallback* user_callback_; + OldCompletionCallbackImpl<FtpNetworkTransaction> io_callback_; + OldCompletionCallback* user_callback_; scoped_refptr<FtpNetworkSession> session_; diff --git a/net/ftp/ftp_network_transaction_unittest.cc b/net/ftp/ftp_network_transaction_unittest.cc index f92561d..6739847 100644 --- a/net/ftp/ftp_network_transaction_unittest.cc +++ b/net/ftp/ftp_network_transaction_unittest.cc @@ -820,7 +820,7 @@ class FtpNetworkTransactionTest : public PlatformTest { scoped_refptr<FtpNetworkSession> session_; MockClientSocketFactory mock_socket_factory_; FtpNetworkTransaction transaction_; - TestCompletionCallback callback_; + TestOldCompletionCallback callback_; }; TEST_F(FtpNetworkTransactionTest, FailedLookup) { diff --git a/net/ftp/ftp_transaction.h b/net/ftp/ftp_transaction.h index 2d1c5d8..300468b 100644 --- a/net/ftp/ftp_transaction.h +++ b/net/ftp/ftp_transaction.h @@ -29,7 +29,7 @@ class NET_EXPORT_PRIVATE FtpTransaction { // Returns OK if the transaction could be started synchronously, which means // that the request was served from the cache (only supported for directory // listings). ERR_IO_PENDING is returned to indicate that the - // CompletionCallback will be notified once response info is available or if + // OldCompletionCallback will be notified once response info is available or if // an IO error occurs. Any other return value indicates that the transaction // could not be started. // @@ -40,22 +40,22 @@ class NET_EXPORT_PRIVATE FtpTransaction { // // Profiling information for the request is saved to |net_log| if non-NULL. virtual int Start(const FtpRequestInfo* request_info, - CompletionCallback* callback, + OldCompletionCallback* callback, const BoundNetLog& net_log) = 0; // Restarts the FTP transaction with authentication credentials. virtual int RestartWithAuth(const string16& username, const string16& password, - CompletionCallback* callback) = 0; + OldCompletionCallback* callback) = 0; // Once response info is available for the transaction, response data may be // read by calling this method. // // Response data is copied into the given buffer and the number of bytes // copied is returned. ERR_IO_PENDING is returned if response data is not - // yet available. The CompletionCallback is notified when the data copy + // yet available. The OldCompletionCallback is notified when the data copy // completes, and it is passed the number of bytes that were successfully - // copied. Or, if a read error occurs, the CompletionCallback is notified of + // copied. Or, if a read error occurs, the OldCompletionCallback is notified of // the error. Any other negative return value indicates that the transaction // could not be read. // @@ -63,7 +63,7 @@ class NET_EXPORT_PRIVATE FtpTransaction { // virtual int Read(IOBuffer* buf, int buf_len, - CompletionCallback* callback) = 0; + OldCompletionCallback* callback) = 0; // Returns the response info for this transaction or NULL if the response // info is not available. |