diff options
| author | wtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-28 01:29:24 +0000 |
|---|---|---|
| committer | wtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-28 01:29:24 +0000 |
| commit | 3f918787e1073e17439e55ed34f23ffdc31f891f (patch) | |
| tree | 3e591f7dc3c54e8859815486057725366532ca22 /net/http/http_auth.h | |
| parent | 0a5f0a187c73e47417511ea2ed988c5b3876f563 (diff) | |
| download | chromium_src-3f918787e1073e17439e55ed34f23ffdc31f891f.zip chromium_src-3f918787e1073e17439e55ed34f23ffdc31f891f.tar.gz chromium_src-3f918787e1073e17439e55ed34f23ffdc31f891f.tar.bz2 | |
Implement the NTLM authentication scheme by porting
Mozilla's implementation.
R=darin,eroman
BUG=6567,6824
Review URL: http://codereview.chromium.org/28144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10667 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/http/http_auth.h')
| -rw-r--r-- | net/http/http_auth.h | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/net/http/http_auth.h b/net/http/http_auth.h index 3bb2a86..7442898 100644 --- a/net/http/http_auth.h +++ b/net/http/http_auth.h @@ -53,6 +53,7 @@ class HttpAuth { IdentitySource source; bool invalid; + // TODO(wtc): |username| and |password| should be string16. std::wstring username; std::wstring password; }; @@ -74,8 +75,14 @@ class HttpAuth { // Iterate through the challenge headers, and pick the best one that // we support. Obtains the implementation class for handling the challenge, - // and passes it back in |*handler|. If no supported challenge was found - // |*handler| is set to NULL. + // and passes it back in |*handler|. If the existing handler in |*handler| + // should continue to be used (such as for the NTLM authentication scheme), + // |*handler| is unchanged. If no supported challenge was found, |*handler| + // is set to NULL. + // + // TODO(wtc): Continuing to use the existing handler in |*handler| (for + // NTLM) is new behavior. Rename ChooseBestChallenge to fully encompass + // what it does now. static void ChooseBestChallenge(const HttpResponseHeaders* headers, Target target, scoped_refptr<HttpAuthHandler>* handler); |