summaryrefslogtreecommitdiffstats
path: root/net/http/http_cache.cc
diff options
context:
space:
mode:
authorjhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-08-19 22:31:10 +0000
committerjhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-08-19 22:31:10 +0000
commite2720618d98a40d85462e084fc3744fac73375e3 (patch)
treed1fa9fbcee3d1b6770c12033b7e17e1c86ce29f7 /net/http/http_cache.cc
parent62c880ac8986131fcd1f1f49f854801b59a7cc1b (diff)
downloadchromium_src-e2720618d98a40d85462e084fc3744fac73375e3.zip
chromium_src-e2720618d98a40d85462e084fc3744fac73375e3.tar.gz
chromium_src-e2720618d98a40d85462e084fc3744fac73375e3.tar.bz2
Add missing break statement.
CID=5724 BUG=none TEST=none Review URL: http://codereview.chromium.org/173078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23766 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/http/http_cache.cc')
-rw-r--r--net/http/http_cache.cc8
1 files changed, 5 insertions, 3 deletions
diff --git a/net/http/http_cache.cc b/net/http/http_cache.cc
index 1299111..23c462e 100644
--- a/net/http/http_cache.cc
+++ b/net/http/http_cache.cc
@@ -5,6 +5,7 @@
#include "net/http/http_cache.h"
#include <algorithm>
+#include <string>
#include "base/compiler_specific.h"
@@ -543,7 +544,7 @@ bool HttpCache::Transaction::IsReadyToRestartForAuth() {
int HttpCache::Transaction::Read(IOBuffer* buf, int buf_len,
CompletionCallback* callback) {
DCHECK(buf);
- DCHECK(buf_len > 0);
+ DCHECK_GT(buf_len, 0);
DCHECK(callback);
DCHECK(!callback_);
@@ -731,6 +732,7 @@ void HttpCache::Transaction::SetRequest(LoadLog* load_log,
// (intentionally). If we read from the cache, we replay them
// prematurely.
effective_load_flags_ |= LOAD_BYPASS_CACHE;
+ break;
case PLAYBACK:
// When in playback mode, we want to load exclusively from the cache.
effective_load_flags_ |= LOAD_ONLY_FROM_CACHE;
@@ -1583,7 +1585,7 @@ HttpCache::~HttpCache() {
HttpTransaction* HttpCache::CreateTransaction() {
// Do lazy initialization of disk cache if needed.
if (!disk_cache_.get()) {
- DCHECK(cache_size_ >= 0);
+ DCHECK_GE(cache_size_, 0);
if (in_memory_cache_) {
// We may end up with no folder name and no cache if the initialization
// of the disk cache fails. We want to be sure that what we wanted to have
@@ -1645,7 +1647,7 @@ bool HttpCache::ReadResponseInfo(disk_cache::Entry* disk_entry,
// read response-headers
response_info->headers = new HttpResponseHeaders(pickle, &iter);
- DCHECK(response_info->headers->response_code() != -1);
+ DCHECK_NE(response_info->headers->response_code(), -1);
// read ssl-info
if (flags & RESPONSE_INFO_HAS_CERT) {