Remove support for "name" parameter from Content-Disposition.

All other UAs don't treat the name value as a synonym. Drop support
from Chrome.

UMA metrics indicate 0.00% actually only contain the "name" attribute.
0.01% of requests had with a name attribute; but had higher preference
values as well. This feature isn't clearly used anymore.

BUG=162815
TEST=net_unittests

Review URL: https://codereview.chromium.org/1107913003

Cr-Commit-Position: refs/heads/master@{#327708}

1 files changed, 8 insertions, 9 deletions

diff --git a/net/http/http_content_disposition.h b/net/http/http_content_disposition.h
index 2b4ca70..c96ba61 100644
--- a/net/http/http_content_disposition.h
+++ b/net/http/http_content_disposition.h
@@ -19,7 +19,9 @@ class NET_EXPORT HttpContentDisposition {
     ATTACHMENT,
   };
 
-  // Properties of the Content-Disposition header. Used for UMA.
+  // Properties of the Content-Disposition header. These flags are used to
+  // report download metrics in UMA. This enum isn't directly used in UMA but
+  // mapped to another one for binary compatiblity; ie. changes are OK.
   enum ParseResultFlags {
     INVALID                      = 0,
 
@@ -29,25 +31,22 @@ class NET_EXPORT HttpContentDisposition {
     // The disposition-type is not 'inline' or 'attachment'.
     HAS_UNKNOWN_DISPOSITION_TYPE = 1 << 1,
 
-    // Has a valid non-empty 'name' attribute.
-    HAS_NAME                     = 1 << 2,
-
     // Has a valid non-empty 'filename' attribute.
-    HAS_FILENAME                 = 1 << 3,
+    HAS_FILENAME                 = 1 << 2,
 
     // Has a valid non-empty 'filename*' attribute.
-    HAS_EXT_FILENAME             = 1 << 4,
+    HAS_EXT_FILENAME             = 1 << 3,
 
     // The following fields are properties of the 'filename' attribute:
 
     // Quoted-string contains non-ASCII characters.
-    HAS_NON_ASCII_STRINGS        = 1 << 5,
+    HAS_NON_ASCII_STRINGS        = 1 << 4,
 
     // Quoted-string contains percent-encoding.
-    HAS_PERCENT_ENCODED_STRINGS  = 1 << 6,
+    HAS_PERCENT_ENCODED_STRINGS  = 1 << 5,
 
     // Quoted-string contains RFC 2047 encoded words.
-    HAS_RFC2047_ENCODED_STRINGS  = 1 << 7
+    HAS_RFC2047_ENCODED_STRINGS  = 1 << 6
   };
 
   HttpContentDisposition(const std::string& header,