diff options
author | battre@chromium.org <battre@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-28 12:28:01 +0000 |
---|---|---|
committer | battre@chromium.org <battre@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-28 12:28:01 +0000 |
commit | 636eccda1e2e716e75d2c27636cbf943c3afb67e (patch) | |
tree | 78f341478014346ca6da5253c52ffd49d75cfaf4 /net/http/http_network_transaction.cc | |
parent | 47126547f951dc36455dce1551e6f893fc30045a (diff) | |
download | chromium_src-636eccda1e2e716e75d2c27636cbf943c3afb67e.zip chromium_src-636eccda1e2e716e75d2c27636cbf943c3afb67e.tar.gz chromium_src-636eccda1e2e716e75d2c27636cbf943c3afb67e.tar.bz2 |
Moved OnBeforeHeadersSent of webRequest API to url_request_http_job.cc
This CL moves the OnBeforeSendHeaders signal from net_http_transaction.cc and net_cache_transaction.cc to url_request_http_job.cc. We do this for several reasons:
- deep in the http stack one URL Request can be split into several http requests
(with different byte ranges).
- We do not want to expose this implementation detail to extension authors.
- It is not sufficient to submit only the first OnBeforeSendHeaders event to
the extension: If the extension modifies the headers, this modification should
apply to all http requests.
- from an architectural perspective we do not want to go too deep in order to
allow changing the network stack implementation without being limited by the
published Extension API (needs to be backwards compatible)
BUG=60101
TEST=no
Review URL: http://codereview.chromium.org/7039010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90753 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/http/http_network_transaction.cc')
-rw-r--r-- | net/http/http_network_transaction.cc | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc index 403f60f..bbd19b3 100644 --- a/net/http/http_network_transaction.cc +++ b/net/http/http_network_transaction.cc @@ -753,11 +753,6 @@ int HttpNetworkTransaction::DoBuildRequest() { BuildRequestHeaders(using_proxy); } - if (session_->network_delegate()) { - return session_->network_delegate()->NotifyBeforeSendHeaders( - request_->request_id, &io_callback_, &request_headers_); - } - return OK; } |