diff options
author | gavinp@google.com <gavinp@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-17 00:58:44 +0000 |
---|---|---|
committer | gavinp@google.com <gavinp@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-17 00:58:44 +0000 |
commit | 2bd930265ee663668e49d41eb35fddd94934eae2 (patch) | |
tree | 995f47c031908b58b5780b228fa405de1b0ff407 /net/http/http_network_transaction.h | |
parent | 485cd456a503e6698c75ea6185ed93de832d493a (diff) | |
download | chromium_src-2bd930265ee663668e49d41eb35fddd94934eae2.zip chromium_src-2bd930265ee663668e49d41eb35fddd94934eae2.tar.gz chromium_src-2bd930265ee663668e49d41eb35fddd94934eae2.tar.bz2 |
Implement MAX_CONCURRENT_STREAMS SETTINGS header
This CL helps chrome respect the SETTINGS header
MAX_CONCURRENT_STREAMS. Note that this means that
SpdySession::CreateStream can now return ERR_IO_PENDING, so it
requires a callback. There's a noted TODO that if an
http_network_transaction dissapears betweeen STATE_SPDY_GET_STREAM and
STATE_SPDY_SEND_REQUEST I don't know if we end up with an orphan stream
in our spdy_session.
As well, spdy_test_util.cc had a lot of functions with default arguments;
I didn't fix them all, but the functions I modified no longer take default
arguments and meet the coding standard. I'd like to circle back at some point
and possibly make the tests call SpdyFramer directly: these test utils seem
sometimes more trouble than they're worth if the framer was a bit more
convenient for direct use.
BUG=34750
TEST=net_unittests Spdy.ThreeGets*
Review URL: http://codereview.chromium.org/2919011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52791 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/http/http_network_transaction.h')
-rw-r--r-- | net/http/http_network_transaction.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/net/http/http_network_transaction.h b/net/http/http_network_transaction.h index 9cca6c1..7c32bd3 100644 --- a/net/http/http_network_transaction.h +++ b/net/http/http_network_transaction.h @@ -95,6 +95,8 @@ class HttpNetworkTransaction : public HttpTransaction { STATE_READ_BODY_COMPLETE, STATE_DRAIN_BODY_FOR_AUTH_RESTART, STATE_DRAIN_BODY_FOR_AUTH_RESTART_COMPLETE, + STATE_SPDY_GET_STREAM, + STATE_SPDY_GET_STREAM_COMPLETE, STATE_SPDY_SEND_REQUEST, STATE_SPDY_SEND_REQUEST_COMPLETE, STATE_SPDY_READ_HEADERS, @@ -136,6 +138,8 @@ class HttpNetworkTransaction : public HttpTransaction { int DoReadBodyComplete(int result); int DoDrainBodyForAuthRestart(); int DoDrainBodyForAuthRestartComplete(int result); + int DoSpdyGetStream(); + int DoSpdyGetStreamComplete(int result); int DoSpdySendRequest(); int DoSpdySendRequestComplete(int result); int DoSpdyReadHeaders(); |