diff options
| author | mmenke@chromium.org <mmenke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-16 14:58:12 +0000 |
|---|---|---|
| committer | mmenke@chromium.org <mmenke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-16 14:58:12 +0000 |
| commit | ecab6e059c4fa90012d9c95aed98697c5f3ecce2 (patch) | |
| tree | 5169966ca20d83da5e333e47e74aa5ee2ff5a292 /net/http/http_stream_parser.cc | |
| parent | 799d9329bb91033d5d17d6cdd05cda13fa5bea7a (diff) | |
| download | chromium_src-ecab6e059c4fa90012d9c95aed98697c5f3ecce2.zip chromium_src-ecab6e059c4fa90012d9c95aed98697c5f3ecce2.tar.gz chromium_src-ecab6e059c4fa90012d9c95aed98697c5f3ecce2.tar.bz2 | |
Remove DCHECK in HttpStreamParser::ReadResponseHeaders.
The DCHECK dereferenced the request's HttpResponseInfo. It turns out
that when an HttpNetworkTransaction is cancelled and an
HttpResponseDrainer is used, the HttpResponseInfo is deleted with the
HttpStreamParser's knowledge.
This CL also adds a pair of tests for the situation.
BUG=368418
Review URL: https://codereview.chromium.org/284913003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271014 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/http/http_stream_parser.cc')
| -rw-r--r-- | net/http/http_stream_parser.cc | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/net/http/http_stream_parser.cc b/net/http/http_stream_parser.cc index 820c1ba..30ba279 100644 --- a/net/http/http_stream_parser.cc +++ b/net/http/http_stream_parser.cc @@ -345,9 +345,6 @@ int HttpStreamParser::ReadResponseBody(IOBuffer* buf, int buf_len, if (io_state_ == STATE_DONE) return OK; - // Must have response headers with a non-1xx error code. - DCHECK_NE(1, response_->headers->response_code() / 100); - user_read_buf_ = buf; user_read_buf_len_ = buf_len; io_state_ = STATE_READ_BODY; |