diff options
| author | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-22 19:03:10 +0000 |
|---|---|---|
| committer | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-22 19:03:10 +0000 |
| commit | 00a160f1bb25b443d21cc5408cdd4e2851618dbd (patch) | |
| tree | edd3b583b4d483767a18a8019b6f49c5d8290461 /net/http/http_transaction.h | |
| parent | 9790156eba13917f6b68f90fdc749c5958ee3f30 (diff) | |
| download | chromium_src-00a160f1bb25b443d21cc5408cdd4e2851618dbd.zip chromium_src-00a160f1bb25b443d21cc5408cdd4e2851618dbd.tar.gz chromium_src-00a160f1bb25b443d21cc5408cdd4e2851618dbd.tar.bz2 | |
Revert 189829 "[Net] Propagate priority changes from URLRequest ..."
See heapcheck failures:
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Heapcheck/builds/25563
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Heapcheck/builds/25563/steps/heapcheck%20test%3A%20net/logs/stdio
Example (one of many):
Leak of 792 bytes in 1 objects allocated from:
@ 10d675b URLRequestFtpJobPriorityTest
@ 10d68e7 URLRequestFtpJobPriorityTest_SetPriorityBasic_Test
@ 10de383 CreateTest
Suppression (error hash=#0A68FF60C5D043B8#):
{
<insert_a_suppression_name_here>
Heapcheck:Leak
fun:URLRequestFtpJobPriorityTest
fun:URLRequestFtpJobPriorityTest_SetPriorityBasic_Test
fun:CreateTest
}
> [Net] Propagate priority changes from URLRequest to HttpTransaction
>
> This is in preparation for propagating priority changes from
> ResourceScheduler all the way to HostResolver and ClientSocketPool.
>
> Add some NetLog events and parameters for priority.
>
> BUG=166689
> TBR=simonjam@chromium.org,sky@chromium.org
>
> Review URL: https://codereview.chromium.org/12701011
TBR=akalin@chromium.org
Review URL: https://codereview.chromium.org/12676022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189872 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/http/http_transaction.h')
| -rw-r--r-- | net/http/http_transaction.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/net/http/http_transaction.h b/net/http/http_transaction.h index c162b01..7b4ab99 100644 --- a/net/http/http_transaction.h +++ b/net/http/http_transaction.h @@ -8,7 +8,6 @@ #include "net/base/completion_callback.h" #include "net/base/load_states.h" #include "net/base/net_export.h" -#include "net/base/request_priority.h" #include "net/base/upload_progress.h" namespace net { @@ -117,9 +116,6 @@ class NET_EXPORT_PRIVATE HttpTransaction { // |load_timing_info| must have all null times when called. Returns false and // does not modify |load_timing_info| if not currently connected. virtual bool GetLoadTimingInfo(LoadTimingInfo* load_timing_info) const = 0; - - // Called when the priority of the parent job changes. - virtual void SetPriority(RequestPriority priority) = 0; }; } // namespace net |