summaryrefslogtreecommitdiffstats
path: root/net/http/http_transaction.h
diff options
context:
space:
mode:
authorericroman@google.com <ericroman@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-27 04:00:22 +0000
committerericroman@google.com <ericroman@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-27 04:00:22 +0000
commit0757e770ac9ce685ee0db0179271f1a3dba47cb0 (patch)
tree54e1a153fd38a9f950187929076a1d5d6966357e /net/http/http_transaction.h
parent3a2d366b664bb0c13f4427f3ed6a3b6af6e77451 (diff)
downloadchromium_src-0757e770ac9ce685ee0db0179271f1a3dba47cb0.zip
chromium_src-0757e770ac9ce685ee0db0179271f1a3dba47cb0.tar.gz
chromium_src-0757e770ac9ce685ee0db0179271f1a3dba47cb0.tar.bz2
Respect cookies set in a 401 responses when restarting the http transaction.
There are two parts to this change: (1) rebuild the request cookies before each transaction restart for authentication (2) notify the URLRequestHttpJob of header completion before *each* transaction restart for authentication By "each transaction" I mean the automatic restarts that don't require user input, such as: - replying to the first step of NTLM - selecting identity embedded in URL - selecting identity in auth-cache Needing to notify URLRequestHttpJob for these intermediate restarts is a consequence of cookie store management being done outside of HttpNetworkTransaction. After updating the cookie store, URLRequestHttpJob now tests |HttpTransaction::IsReadyToRestartForAuth()| to check whether the notification was informational or an identity is actually needed. R=wtc BUG=6450 Review URL: http://codereview.chromium.org/51004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12635 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/http/http_transaction.h')
-rw-r--r--net/http/http_transaction.h8
1 files changed, 8 insertions, 0 deletions
diff --git a/net/http/http_transaction.h b/net/http/http_transaction.h
index 2c857ed..cc7dd92 100644
--- a/net/http/http_transaction.h
+++ b/net/http/http_transaction.h
@@ -55,6 +55,14 @@ class HttpTransaction {
const std::wstring& password,
CompletionCallback* callback) = 0;
+ // Returns true if auth is ready to be continued. Callers should check
+ // this value anytime Start() completes: if it is true, the transaction
+ // can be resumed with RestartWithAuth(L"", L"", callback) to resume
+ // the automatic auth exchange. This notification gives the caller a
+ // chance to process the response headers from all of the intermediate
+ // restarts needed for authentication.
+ virtual bool IsReadyToRestartForAuth() = 0;
+
// Once response info is available for the transaction, response data may be
// read by calling this method.
//