diff options
| author | rvargas@google.com <rvargas@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-24 01:54:05 +0000 |
|---|---|---|
| committer | rvargas@google.com <rvargas@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-24 01:54:05 +0000 |
| commit | 1f8859ad6ec7ea807c0330ddf5559e13be5fb26c (patch) | |
| tree | 68887107d0d40f1b22c7a7a07ccd9d7e4caf157a /net/http/http_transaction.h | |
| parent | 13dc122db24457653d57ff07791043d518eb05e7 (diff) | |
| download | chromium_src-1f8859ad6ec7ea807c0330ddf5559e13be5fb26c.zip chromium_src-1f8859ad6ec7ea807c0330ddf5559e13be5fb26c.tar.gz chromium_src-1f8859ad6ec7ea807c0330ddf5559e13be5fb26c.tar.bz2 | |
Change URLRequest to use a ref-counted buffer for actual IO.The ref-counting will prevent the deletion / reuse of memorywhile the buffer is actually being used by pending IO.This seems a very intrusive change, but at least we will be ableto make sure that it works without having to chase every singledestruction of an URLRequest to make sure that any pending IOwas cancelled, and also allows us to avoid blocking onthe object destruction.BUG=5325
Review URL: http://codereview.chromium.org/18390
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8603 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/http/http_transaction.h')
| -rw-r--r-- | net/http/http_transaction.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/net/http/http_transaction.h b/net/http/http_transaction.h index ba2cf29..46c7671 100644 --- a/net/http/http_transaction.h +++ b/net/http/http_transaction.h @@ -66,8 +66,11 @@ class HttpTransaction { // could not be read. // // NOTE: The transaction is not responsible for deleting the callback object. + // If the operation is not completed immediately, the transaction must acquire + // a reference to the provided buffer. // - virtual int Read(char* buf, int buf_len, CompletionCallback* callback) = 0; + virtual int Read(IOBuffer* buf, int buf_len, + CompletionCallback* callback) = 0; // Returns the response info for this transaction or NULL if the response // info is not available. |