diff options
author | mmenke@chromium.org <mmenke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-24 18:41:00 +0000 |
---|---|---|
committer | mmenke@chromium.org <mmenke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-24 18:41:00 +0000 |
commit | e50efeac41b673778ab12a6a47208549e2ab4bf7 (patch) | |
tree | 24ae0c7c40718669a2e750b43041c6b16a27fd0b /net/http/http_transaction_unittest.cc | |
parent | df287e13e02af1f2e795c5a88400543da42a1f28 (diff) | |
download | chromium_src-e50efeac41b673778ab12a6a47208549e2ab4bf7.zip chromium_src-e50efeac41b673778ab12a6a47208549e2ab4bf7.tar.gz chromium_src-e50efeac41b673778ab12a6a47208549e2ab4bf7.tar.bz2 |
Don't cache non-redirect HTTP responses when a redirect is forced
by a NetworkDelegate in OnHeadersReceived. This regressed in
https://chromiumcodereview.appspot.com/23710059.
Fortunately, no NetworkDelegate currently does this, but that is
going to change.
BUG=354508
Review URL: https://codereview.chromium.org/208683002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258983 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/http/http_transaction_unittest.cc')
-rw-r--r-- | net/http/http_transaction_unittest.cc | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/net/http/http_transaction_unittest.cc b/net/http/http_transaction_unittest.cc index fe904d90..eed3c4f 100644 --- a/net/http/http_transaction_unittest.cc +++ b/net/http/http_transaction_unittest.cc @@ -296,7 +296,10 @@ int MockNetworkTransaction::Read(net::IOBuffer* buf, int buf_len, return net::ERR_IO_PENDING; } -void MockNetworkTransaction::StopCaching() {} +void MockNetworkTransaction::StopCaching() { + if (transaction_factory_.get()) + transaction_factory_->TransactionStopCaching(); +} bool MockNetworkTransaction::GetFullRequestHeaders( net::HttpRequestHeaders* headers) const { @@ -439,6 +442,7 @@ void MockNetworkTransaction::RunCallback( MockNetworkLayer::MockNetworkLayer() : transaction_count_(0), done_reading_called_(false), + stop_caching_called_(false), last_create_transaction_priority_(net::DEFAULT_PRIORITY) {} MockNetworkLayer::~MockNetworkLayer() {} @@ -447,6 +451,10 @@ void MockNetworkLayer::TransactionDoneReading() { done_reading_called_ = true; } +void MockNetworkLayer::TransactionStopCaching() { + stop_caching_called_ = true; +} + int MockNetworkLayer::CreateTransaction( net::RequestPriority priority, scoped_ptr<net::HttpTransaction>* trans) { |